Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve embed experience #286

Merged
merged 1 commit into from
Oct 30, 2020
Merged

feat: improve embed experience #286

merged 1 commit into from
Oct 30, 2020

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Oct 30, 2020

What:
Improve the user experience for embedding.

  • Default frame height has been increased from 300px to 450px;
  • Embed modal now saves state prior to showing embed code, instead of showing the "unsaved changes warning"

Why:
Nicer like this.

How:

Checklist:

  • Tests
  • Ready to be merged

@smeijer smeijer added the feature New feature or request label Oct 30, 2020
@smeijer smeijer self-assigned this Oct 30, 2020
@smeijer smeijer merged commit 7f1dad6 into develop Oct 30, 2020
@smeijer smeijer deleted the feature/improve-embed-ux branch October 30, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smeijer smeijer

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smeijer