Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist cursor position on paste #298

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

aganglada
Copy link
Collaborator

What:
This PR fixes #297 keeping the Editor cursor cursor in the right position after paste event.

Why:

To fix #297

How:

Calculating the last position based on the text pasted and moving the cursor there.

Checklist:

  • Tests N/A
  • Ready to be merged

@smeijer smeijer changed the title Fixed cursor position on paste fix: persist cursor position on paste Nov 14, 2020
@smeijer smeijer merged commit e117f28 into testing-library:develop Nov 14, 2020
@smeijer
Copy link
Member

smeijer commented Nov 14, 2020

Thanks! Much appreciated.

@smeijer
Copy link
Member

smeijer commented Nov 14, 2020

@all-contributors please add @aganglada for code

@allcontributors
Copy link
Contributor

@smeijer

I've put up a pull request to add @aganglada! 🎉

@aganglada aganglada deleted the bug/fix-cursor-on-paste branch November 16, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor jumps to the very beginning of the editor on pasting a copied string
2 participants