-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it embeddable #9
Comments
Let me know whenever this is possible, so I can add it as a built-in transformer for |
@MichaelDeBoey, do you have idea's about how it should look? What kind of functionality you would want in embed mode? |
@smeijer If you look at @codesandbox or @codepen, you see it's always a miniature version of the real app. They're both providing an oembed endpoint, which returns an object with an |
Thanks, I have something to read tomorrow 👍 Never heard of oembed before. |
@MichaelDeBoey , embed mode is almost done. But I'm not sure how soon I will have oembed implemented. As that requires a server side (beyond static hosting), I need to figure a few things out. Maybe it's possible via netlify functions, but I've never worked with those before. Preview can be seen here: https://codepen.io/smeijer/pen/yLYWZmK |
Been working a bit more on it, I don't think that oembed will be that hard after all :) |
@smeijer It really looks nice! |
@MichaelDeBoey , embeddable is done! We support The custom embedding can be seen here: https://codepen.io/smeijer/pen/yLYWZmK?editors=1000 The |
To answer your question, yes, it renders the thing in an The reason I used an iframe is because the playground contains user-generated HTML. So if we would render it in a |
@smeijer Providing an I'll check it out later today and I'll let you know if I need some extra info or I think something isn't working like it should be 😉 |
Please let me know when you have something working as well 😇 , can't wait to see it in action. |
I've created MichaelDeBoey/gatsby-remark-embedder#123 with the reason to drop it soon 😉 |
@smeijer If you wanna take a go on it yourself btw, it can be yours 😉 |
I haven't worked with iframely yet, so would have to look it up myself.
I can probably do it faster, but I like to help people getting into the plugin. |
Not really, I have plenty of other things to do. So if you can do that, it would be much appreciated. I've just completed the application at embed.ly. Let's see how that goes. |
Gonna eat and I'll create a PR for Testing Playground support 🙂 |
Wooohooo!! 🎉🎉🎉 |
How awesome would it be if we had an embed-mode, so users can embed the playground in the blogs they write about testing / testing-library?
Resources:
The text was updated successfully, but these errors were encountered: