Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for upcoming v8 #43

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

christian-bromann
Copy link
Contributor

fixes #42

@olivierwilkinson
Copy link
Collaborator

So the tests are only failing due to the Chrome version on the Ubuntu container being behind the latest Chromedriver version used by the selenium-standalone service. I've verified they pass locally and have fixed the build on main so I'm going to merge this. We use semantic-release so I need to update the commit format when I merge to trigger a release.

Thanks again for raising this. I'm really happy we now support v8, before it's released no less!

@olivierwilkinson olivierwilkinson merged commit 50035bb into testing-library:main Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@christian-bromann
Copy link
Contributor Author

Thanks for merging so quickly! I am currently working on a component testing service for WebdriverIO and wanted to make sure folks can use this library too.

@olivierwilkinson
Copy link
Collaborator

Thanks for merging so quickly!

No problem at all 😄

I am currently working on a component testing service for WebdriverIO and wanted to make sure folks can use this library too.

Oh that's an interesting project! Not having to spin up and navigate a whole app to get to the component in a real environment sounds awsome. Integration testing a complex component with jsdom is difficult or contrived sometimes for sure. Taking existing jsdom integration tests that use @testing-library/dom and translating them to use this library would be pretty easy too (but of course I would say that haha)

@christian-bromann
Copy link
Contributor Author

Give it a whirl and raise issues if you have any feedback. Some things I have on my list before making an announcement is:

  • fix support for react (currently the vite server chokes on rendering React components)
  • support for DOM snapshots in expect-webdriverio
  • mocking and stubbing functionlity, e.g. allow to pass in an onClose method as parameter and validate if it got called after certain interaction
  • documentation, component testing guide, blog post

@olivierwilkinson
Copy link
Collaborator

Give it a whirl and raise issues if you have any feedback.

Will do! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with v8 of WebdriverIO
2 participants