Upgrade @testing-library/dom to better support shadow dom queries #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierwilkinson
force-pushed
the
main
branch
from
e29e8c8
to
36b1a5d
Compare
olivierwilkinson
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
LGTM!
I had a look at the v8 release for DTL and it looks like all the breaking changes are for APIs this library doesn't expose so I'll release this as a feature instead of a breaking change. The waitFor timeout and interval stuff has an impact on findBy queries but it seems like it only matters if the global clock is mocked out by Jest which we don't need to worry about.
Thanks for raising the PR 😄
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where aria-labels for specific elements might be contained in a shadow dom