Rubocop auto-correct

sebazai · sebazai · commit bad71b334329 · 2020-12-04T14:33:53.000+02:00
diff --git a/app/background_tasks/kafka_batch_update_points_task.rb b/app/background_tasks/kafka_batch_update_points_task.rb
@@ -61,7 +61,7 @@ def update_user_progress(task)
       points_per_user = AwardedPoint.count_per_user_in_course_with_sheet(course, parts, user)
       available_points = AvailablePoint.course_sheet_points(course, parts)
       unless points_per_user[user.username]
-        Rails.logger.info("No points found. Skipping")
+        Rails.logger.info('No points found. Skipping')
         return true
       end
       progress = points_per_user[user.username].map do |group_name, awarded_points|
diff --git a/app/background_tasks/sandbox_status_fetcher_task.rb b/app/background_tasks/sandbox_status_fetcher_task.rb
@@ -22,7 +22,7 @@ def run
       data[:fetching_time] = fetching_time.real.round(2)
       data
     end
-    Rails.cache.write("sandbox-status-cache", data.to_json, expires_in: 1.minute)
+    Rails.cache.write('sandbox-status-cache', data.to_json, expires_in: 1.minute)
   end
 
   def wait_delay
diff --git a/app/background_tasks/stats_fetcher_task.rb b/app/background_tasks/stats_fetcher_task.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class StatsFetcherTask
   def initialize
   end
@@ -14,7 +16,7 @@ def run
       submissions_count_yesterday: Submission.where(created_at: Time.current.yesterday.all_day).count,
       submissions_count_week: Submission.where(created_at: Time.current.all_week).count,
     }
-    Rails.cache.write("stats-cache", data.to_json, expires_in: 1.minute)
+    Rails.cache.write('stats-cache', data.to_json, expires_in: 1.minute)
   end
 
   def wait_delay
diff --git a/app/background_tasks/uncomputed_unlock_computor_task.rb b/app/background_tasks/uncomputed_unlock_computor_task.rb
@@ -7,7 +7,7 @@ def initialize
   end
 
   def run
-    UncomputedUnlock.order("id ASC").limit(1).each do |uncomputed_unlock|
+    UncomputedUnlock.order('id ASC').limit(1).each do |uncomputed_unlock|
       course = uncomputed_unlock.course
       user = uncomputed_unlock.user
       Rails.logger.info "Calculating unlocks for user #{user.id} and course #{course.name}. Queue length: #{UncomputedUnlock.count}."
diff --git a/app/controllers/api/v8/base_controller.rb b/app/controllers/api/v8/base_controller.rb
@@ -53,15 +53,15 @@ def errors_json(messages)
         def respond_not_found(msg = 'Not Found')
           respond_with_error(msg, 404)
         end
-    
+
         def respond_forbidden(msg = 'Forbidden')
           respond_with_error(msg, 403)
         end
-    
+
         def respond_unauthorized(msg = 'Authentication required')
           respond_with_error(msg, 401)
         end
-    
+
         def respond_with_error(msg, code = 500, exception = nil, extra_json_keys = {})
           respond_to do |format|
             format.html do
diff --git a/app/controllers/api/v8/core/exercises/details_controller.rb b/app/controllers/api/v8/core/exercises/details_controller.rb
@@ -1,69 +1,68 @@
 # frozen_string_literal: true
 
 module Api
-    module V8
-      module Core
-        module Exercises
-          class DetailsController < Api::V8::BaseController
-            include Swagger::Blocks
+  module V8
+    module Core
+      module Exercises
+        class DetailsController < Api::V8::BaseController
+          include Swagger::Blocks
 
-            swagger_path '/api/v8/core/exercises/details' do
-              operation :get do
-                key :description, 'Fetch multiple exercise details as query parameters.'
-                key :operationId, 'getExerciseDetailsWithIds'
-                key :produces, ['application/json']
-                key :tags, ['core']
-                parameter do
-                  key :in, 'query'
-                  key :name, 'ids'
-                  schema do
-                    key :type, :array
-                    items do
-                      key :type, :integer
-                    end
-                  end
+          swagger_path '/api/v8/core/exercises/details' do
+            operation :get do
+              key :description, 'Fetch multiple exercise details as query parameters.'
+              key :operationId, 'getExerciseDetailsWithIds'
+              key :produces, ['application/json']
+              key :tags, ['core']
+              parameter do
+                key :in, 'query'
+                key :name, 'ids'
+                schema do
                   key :type, :array
-                  key :description, 'Exercise Ids'
+                  items do
+                    key :type, :integer
+                  end
                 end
-                response 200 do
-                  key :description, 'Exercises in json'
-                  schema do
-                    key :title, :exercises
-                    key :required, [:exercises]
-                    property :exercises do
-                      key :type, :array
-                      items do
-                        key :'$ref', :CoreExerciseQueryDetails
-                      end
+                key :type, :array
+                key :description, 'Exercise Ids'
+              end
+              response 200 do
+                key :description, 'Exercises in json'
+                schema do
+                  key :title, :exercises
+                  key :required, [:exercises]
+                  property :exercises do
+                    key :type, :array
+                    items do
+                      key :'$ref', :CoreExerciseQueryDetails
                     end
                   end
                 end
-                response 403, '$ref': '#/responses/error'
-                response 404, '$ref': '#/responses/error'
               end
+              response 403, '$ref': '#/responses/error'
+              response 404, '$ref': '#/responses/error'
             end
+          end
 
-            skip_authorization_check
+          skip_authorization_check
 
-            def show
-              exercise_ids = params[:ids]
-              return respond_not_found('Query param ids is empty. Example: ?ids=1,2,3') if !exercise_ids.present? || exercise_ids.empty?
+          def show
+            exercise_ids = params[:ids]
+            return respond_not_found('Query param ids is empty. Example: ?ids=1,2,3') if !exercise_ids.present? || exercise_ids.empty?
 
-              exercises = Exercise.where(id: exercise_ids.split(",")).includes(:course)
-              authorize! :read, exercises
-              data = exercises.map do |exercise|
-                {
-                  id: exercise.id,
-                  checksum: exercise.checksum,
-                  course_name: exercise.course.name,
-                  exercise_name: exercise.name,
-                } 
-              end
-              present exercises: data
+            exercises = Exercise.where(id: exercise_ids.split(',')).includes(:course)
+            authorize! :read, exercises
+            data = exercises.map do |exercise|
+              {
+                id: exercise.id,
+                checksum: exercise.checksum,
+                course_name: exercise.course.name,
+                exercise_name: exercise.name,
+              }
             end
+            present exercises: data
           end
         end
       end
     end
   end
-  
+end
diff --git a/app/controllers/api/v8/user_app_datum_controller.rb b/app/controllers/api/v8/user_app_datum_controller.rb
@@ -3,14 +3,13 @@
 module Api
   module V8
     class UserAppDatumController < Api::V8::BaseController
-
       skip_authorization_check
       def index
         only_admins!
 
         if params[:after]
           timestamp = Time.zone.parse(params[:after])
-          data = UserAppDatum.where("created_at >= ? OR updated_at >= ?", timestamp, timestamp)
+          data = UserAppDatum.where('created_at >= ? OR updated_at >= ?', timestamp, timestamp)
           return render json: data
         end
 
diff --git a/app/controllers/api/v8/user_field_value_controller.rb b/app/controllers/api/v8/user_field_value_controller.rb
@@ -3,14 +3,13 @@
 module Api
   module V8
     class UserFieldValueController < Api::V8::BaseController
-
       skip_authorization_check
       def index
         only_admins!
 
         if params[:after]
           timestamp = Time.zone.parse(params[:after])
-          data = UserFieldValue.order(:updated_at).where("created_at >= ? OR updated_at >= ?", timestamp, timestamp)
+          data = UserFieldValue.order(:updated_at).where('created_at >= ? OR updated_at >= ?', timestamp, timestamp)
           return render json: data
         end
 
diff --git a/app/controllers/api/v8/users/basic_info_by_emails_controller.rb b/app/controllers/api/v8/users/basic_info_by_emails_controller.rb
@@ -81,11 +81,11 @@ def create
               d[:extra_fields] = extra_fields.map { |o| [o.field_name, o.value] }.to_h
             end
             if params[:user_fields]
-              user_fields = u.user_field_values.map {|o| [o.field_name, o.value]}.to_h
+              user_fields = u.user_field_values.map { |o| [o.field_name, o.value] }.to_h
               d[:user_fields] = user_fields
-              d[:student_number] = user_fields["organizational_id"]
-              d[:first_name] = user_fields["first_name"]
-              d[:last_name] = user_fields["last_name"]
+              d[:student_number] = user_fields['organizational_id']
+              d[:first_name] = user_fields['first_name']
+              d[:last_name] = user_fields['last_name']
             end
             d
           end
diff --git a/app/controllers/api/v8/users/basic_info_by_ids_controller.rb b/app/controllers/api/v8/users/basic_info_by_ids_controller.rb
@@ -31,11 +31,11 @@ def create
               d[:extra_fields] = extra_fields.map { |o| [o.field_name, o.value] }.to_h
             end
             if params[:user_fields]
-              user_fields = u.user_field_values.map {|o| [o.field_name, o.value]}.to_h
+              user_fields = u.user_field_values.map { |o| [o.field_name, o.value] }.to_h
               d[:user_fields] = user_fields
-              d[:student_number] = user_fields["organizational_id"]
-              d[:first_name] = user_fields["first_name"]
-              d[:last_name] = user_fields["last_name"]
+              d[:student_number] = user_fields['organizational_id']
+              d[:first_name] = user_fields['first_name']
+              d[:last_name] = user_fields['last_name']
             end
             d
           end
diff --git a/app/controllers/api/v8/users/basic_info_by_usernames_controller.rb b/app/controllers/api/v8/users/basic_info_by_usernames_controller.rb
@@ -83,11 +83,11 @@ def create
               d[:extra_fields] = extra_fields.map { |o| [o.field_name, o.value] }.to_h
             end
             if params[:user_fields]
-              user_fields = u.user_field_values.map {|o| [o.field_name, o.value]}.to_h
+              user_fields = u.user_field_values.map { |o| [o.field_name, o.value] }.to_h
               d[:user_fields] = user_fields
-              d[:student_number] = user_fields["organizational_id"]
-              d[:first_name] = user_fields["first_name"]
-              d[:last_name] = user_fields["last_name"]
+              d[:student_number] = user_fields['organizational_id']
+              d[:first_name] = user_fields['first_name']
+              d[:last_name] = user_fields['last_name']
             end
             d
           end
diff --git a/app/controllers/results_controller.rb b/app/controllers/results_controller.rb
@@ -12,7 +12,7 @@ def create
 
     # The sandbox output may contain broken characters e.g. if the student
     # pointed a C char* towards some patch of interesting memory :)
-    filtered_params = Hash[(params.keys-["result"]).map do |k|
+    filtered_params = Hash[(params.keys - ['result']).map do |k|
       [k, view_context.force_utf8_violently(params[k])]
     end]
 
diff --git a/app/controllers/solutions_controller.rb b/app/controllers/solutions_controller.rb
@@ -18,7 +18,7 @@ def show
       if current_user.guest?
         raise CanCan::AccessDenied
       elsif !current_user.email_verified?
-        return respond_forbidden("Please verify your email address in order to see solutions.")
+        return respond_forbidden('Please verify your email address in order to see solutions.')
       elsif current_user.teacher?(@organization) || current_user.assistant?(@course)
         return respond_forbidden("You can't see model solutions until organization is verified by administrator")
       else
diff --git a/app/controllers/status_controller.rb b/app/controllers/status_controller.rb
@@ -4,9 +4,9 @@
 class StatusController < ApplicationController
   def index
     authorize! :read_instance_state, nil
-    @stats = Rails.cache.fetch("stats-cache")
+    @stats = Rails.cache.fetch('stats-cache')
     @stats = JSON.parse(@stats) if @stats
-    @sandboxes = Rails.cache.fetch("sandbox-status-cache")
+    @sandboxes = Rails.cache.fetch('sandbox-status-cache')
     @sandboxes = JSON.parse(@sandboxes) if @sandboxes
   end
 end
diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb
@@ -335,13 +335,13 @@ def check_access!
               respond_forbidden("You cannot see this paste because you haven't completed this exercise.")
               return
             else
-              respond_forbidden("You cannot see this paste because it was created over 2 hours ago.")
+              respond_forbidden('You cannot see this paste because it was created over 2 hours ago.')
             end
             return
           end
         end
 
-        respond_forbidden("You cannot see this paste because all tests passed.") unless paste_visible
+        respond_forbidden('You cannot see this paste because all tests passed.') unless paste_visible
       end
     end
 end
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
@@ -16,7 +16,7 @@ def index
 
   def new
     authorize! :create, User
-    alternative_location = SiteSetting.all_settings["signup_location"]
+    alternative_location = SiteSetting.all_settings['signup_location']
     return redirect_to alternative_location if alternative_location
     add_breadcrumb 'Sign up', new_user_path
 
diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb
@@ -8,29 +8,29 @@ def email_confirmation(user, origin = nil, language = nil)
     @user = user
     token = user.verification_tokens.email.create!
     @url = base_url + confirm_email_path(@user.id, token.token, language: language)
-    subject = 'Confirm your mooc.fi account email address' if language == "en" || language == "en-lu"
-    subject = 'Varmista mooc.fi tunnuksesi sähköpostiosoite' if language == "fi"
-    subject = 'Bekräfta e-postadressen till ditt mooc.fi-konto' if language == "se"
-    subject = 'Bestätige deine E-Mail-Adresse, um mit dem Kurs zu beginnen' if language == "de" || language == "de-at"
-    subject = 'Palun kinnita oma e-posti aadress' if language == "ee"
-    subject = 'Bekreft email adressen din' if language == "no"
-    subject = 'Apstipriniet savu e-pasta adresi, lai sāktu darbu ar AI' if language == "lv"
-    subject = 'Confirmez votre adresse électronique pour commencer le cours «Elements of AI».' if language == "fr" || language == "fr-be"
-    subject = 'Hagyd jóvá az email-címed az Elements of AI/Az MI alapjai -kurzus megkezdéséhez' if language == "hu"
-    subject = 'Potvrdenie e-mailovej adresy pred začiatkom kurzu Elements of AI' if language == "sk"
-    subject = 'Confirmați adresa dumneavoastră de e-mail pentru a începe cursul „Elements of AI”.' if language == "ro"
-    subject = 'Ikkonferma l-indirizz elettroniku tiegħek għall-kors Elements of AI' if language == "mt"
-    subject = 'Aby rozpocząć kurs „Elements of AI” potwierdź Twój adres e-mail.' if language == "pl"
-    subject = 'Confirme o seu endereço eletrónico para iniciar o curso «Elements of AI»' if language == "pt"
-    subject = 'Confirma tu dirección de correo electrónico para empezar a trabajar con Elements of AI' if language == "es"
-    subject = 'Deimhnigh do sheoladh ríomhphoist chun tús a chur leis an gcúrsa Elements of AI' if language == "ga"
-    subject = 'Bevestig je e-mailadres om te beginnen aan Elements of AI' if language == "nl" || language == "nl-be"
-    subject = 'Da biste započeli s tečajem Elements of AI, potvrdite svoju e-adresu.' if language == "hr"
-    subject = 'Potrdite svoj e-naslov za začetek tečaja Elements of AI.' if language == "sl"
-    subject = 'Jei norite pradėti kursą „Elements of AI“, patvirtinkite savo e. pašto adresą.' if language == "lt"
-    subject = 'Επιβεβαιώστε την ηλεκτρονική σας διεύθυνση για να ξεκινήσετε τον κύκλο μαθημάτων «Elements of AI».' if language == "el"
-    subject = 'Потвърдете своя имейл, за да започнете курса „Elements of AI“.' if language == "bg"
-    subject = 'Conferma il tuo indirizzo e-mail per cominciare il corso Elements of AI' if language == "it"
+    subject = 'Confirm your mooc.fi account email address' if language == 'en' || language == 'en-lu'
+    subject = 'Varmista mooc.fi tunnuksesi sähköpostiosoite' if language == 'fi'
+    subject = 'Bekräfta e-postadressen till ditt mooc.fi-konto' if language == 'se'
+    subject = 'Bestätige deine E-Mail-Adresse, um mit dem Kurs zu beginnen' if language == 'de' || language == 'de-at'
+    subject = 'Palun kinnita oma e-posti aadress' if language == 'ee'
+    subject = 'Bekreft email adressen din' if language == 'no'
+    subject = 'Apstipriniet savu e-pasta adresi, lai sāktu darbu ar AI' if language == 'lv'
+    subject = 'Confirmez votre adresse électronique pour commencer le cours «Elements of AI».' if language == 'fr' || language == 'fr-be'
+    subject = 'Hagyd jóvá az email-címed az Elements of AI/Az MI alapjai -kurzus megkezdéséhez' if language == 'hu'
+    subject = 'Potvrdenie e-mailovej adresy pred začiatkom kurzu Elements of AI' if language == 'sk'
+    subject = 'Confirmați adresa dumneavoastră de e-mail pentru a începe cursul „Elements of AI”.' if language == 'ro'
+    subject = 'Ikkonferma l-indirizz elettroniku tiegħek għall-kors Elements of AI' if language == 'mt'
+    subject = 'Aby rozpocząć kurs „Elements of AI” potwierdź Twój adres e-mail.' if language == 'pl'
+    subject = 'Confirme o seu endereço eletrónico para iniciar o curso «Elements of AI»' if language == 'pt'
+    subject = 'Confirma tu dirección de correo electrónico para empezar a trabajar con Elements of AI' if language == 'es'
+    subject = 'Deimhnigh do sheoladh ríomhphoist chun tús a chur leis an gcúrsa Elements of AI' if language == 'ga'
+    subject = 'Bevestig je e-mailadres om te beginnen aan Elements of AI' if language == 'nl' || language == 'nl-be'
+    subject = 'Da biste započeli s tečajem Elements of AI, potvrdite svoju e-adresu.' if language == 'hr'
+    subject = 'Potrdite svoj e-naslov za začetek tečaja Elements of AI.' if language == 'sl'
+    subject = 'Jei norite pradėti kursą „Elements of AI“, patvirtinkite savo e. pašto adresą.' if language == 'lt'
+    subject = 'Επιβεβαιώστε την ηλεκτρονική σας διεύθυνση για να ξεκινήσετε τον κύκλο μαθημάτων «Elements of AI».' if language == 'el'
+    subject = 'Потвърдете своя имейл, за да започнете курса „Elements of AI“.' if language == 'bg'
+    subject = 'Conferma il tuo indirizzo e-mail per cominciare il corso Elements of AI' if language == 'it'
     subject = "#{origin}: #{subject}" if origin
     if origin
       origin_name = origin.downcase.tr(' ', '_').gsub(/[\.\/]/, '')
diff --git a/app/models/kafka_batch_update_points.rb b/app/models/kafka_batch_update_points.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class KafkaBatchUpdatePoints < ActiveRecord::Base
   belongs_to :course
 end
diff --git a/app/models/solution.rb b/app/models/solution.rb
@@ -14,7 +14,7 @@ def path
     @exercise.solution_path
   end
 
-  def visible_to?(user, ignore_email_verification=false)
+  def visible_to?(user, ignore_email_verification = false)
     if user.administrator?
       true
     elsif !ignore_email_verification && !user.email_verified?
diff --git a/app/models/unlock.rb b/app/models/unlock.rb
@@ -25,7 +25,7 @@ def self.refresh_unlocks(course, user)
       unlocks = course.unlocks.where(user_id: user.id)
       by_exercise_name = Hash[unlocks.map { |u| [u.exercise_name, u] }]
       fast_refresh_unlocks_impl(course, user, by_exercise_name)
-      UncomputedUnlock.where(course_id: course.id, user_id: user.id).where("created_at < ?", time).delete_all
+      UncomputedUnlock.where(course_id: course.id, user_id: user.id).where('created_at < ?', time).delete_all
     end
   end
 
diff --git a/config.ru b/config.ru
@@ -5,5 +5,5 @@
 require ::File.expand_path('../config/environment', __FILE__)
 run TmcServer::Application
 
-require "rack/attack"
+require 'rack/attack'
 use Rack::Attack
diff --git a/config/environments/production.rb b/config/environments/production.rb
diff --git a/config/initializers/mini_profiler.rb b/config/initializers/mini_profiler.rb
diff --git a/config/initializers/rack_attack.rb b/config/initializers/rack_attack.rb
diff --git a/lib/sandbox_results_saver.rb b/lib/sandbox_results_saver.rb
diff --git a/lib/submission_packager.rb b/lib/submission_packager.rb
diff --git a/lib/tmc_langs.rb b/lib/tmc_langs.rb
diff --git a/spec/controllers/api/v8/core/submissions/feedback_controller_spec.rb b/spec/controllers/api/v8/core/submissions/feedback_controller_spec.rb
diff --git a/spec/factories.rb b/spec/factories.rb
diff --git a/spec/lib/test_run_grader_spec.rb b/spec/lib/test_run_grader_spec.rb
