Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript types not included in published package? #412

Open
darcien opened this issue Oct 3, 2024 · 1 comment
Open

TypeScript types not included in published package? #412

darcien opened this issue Oct 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@darcien
Copy link

darcien commented Oct 3, 2024

Describe the bug

The published npm package does not include the TS declaration files.
Are there any reason why the TS types is not published?

To Reproduce
Steps to reproduce the behavior:

  1. Install @testomatio/reporter in a TS project
  2. Import @testomatio/reporter in a TS file
  3. See error Could not find a declaration file for module '@testomatio/reporter'.

Expected behavior

No TS error when importing the package.

Additional context

Package does have a typings field

"typings": "typings/index.d.ts",

The repository seems to contains TS typings albeit it doesn't match the package.
https://github.com/testomatio/reporter/blob/0535badc762120ec11ed301bb55d6e7bb49104e0/types.d.ts

But the files field in package.json does not include the path specified in typings.

reporter/package.json

Lines 39 to 43 in 0535bad

"files": [
"bin",
"lib",
"testcafe"
],

No typings in the published package:
image

I also checked npm to see if the types are published separately, e.g. @types/testomatio__reporter, doesn't exist.

@darcien darcien added the bug Something isn't working label Oct 3, 2024
@olexandr13
Copy link
Collaborator

@darcien thanks for your contribution
we will release a new version with based on ESM, it will support typings
~ within a month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants