Skip to content

Commit 212bdbb

Browse files
authored
Merge pull request #2485 from drwetter/fix_CAARRquery_noDNS_30
Fix CAA query when nodns set
2 parents 30c0359 + 83059ca commit 212bdbb

File tree

1 file changed

+26
-23
lines changed

1 file changed

+26
-23
lines changed

testssl.sh

+26-23
Original file line numberDiff line numberDiff line change
@@ -9111,32 +9111,35 @@ certificate_info() {
91119111
jsonID="DNS_CAArecord"
91129112
caa_node="$NODE"
91139113
caa=""
9114-
while ( [[ -z "$caa" ]] && [[ ! -z "$caa_node" ]] ); do
9115-
caa="$(get_caa_rr_record $caa_node)"
9116-
[[ $caa_node =~ '.'$ ]] || caa_node+="."
9117-
caa_node=${caa_node#*.}
9118-
done
9119-
if [[ -n "$caa" ]]; then
9120-
pr_svrty_good "available"; out " - please check for match with \"Issuer\" above"
9121-
if [[ $(count_lines "$caa") -eq 1 ]]; then
9122-
out ": "
9123-
else
9124-
outln; out "$spaces"
9125-
fi
9126-
while read caa; do
9127-
if [[ -n "$caa" ]]; then
9128-
all_caa+="$caa, "
9129-
fi
9130-
done <<< "$caa"
9131-
all_caa=${all_caa%, } # strip trailing comma
9132-
pr_italic "$(out_row_aligned_max_width "$all_caa" "$indent " $TERM_WIDTH)"
9133-
fileout "${jsonID}${json_postfix}" "OK" "$all_caa"
9134-
elif [[ -n "$NODNS" ]]; then
9114+
9115+
if [[ -n "$NODNS" ]]; then
91359116
out "(instructed to minimize DNS queries)"
91369117
fileout "${jsonID}${json_postfix}" "INFO" "check skipped as instructed"
91379118
else
9138-
pr_svrty_low "not offered"
9139-
fileout "${jsonID}${json_postfix}" "LOW" "--"
9119+
while ( [[ -z "$caa" ]] && [[ ! -z "$caa_node" ]] ); do
9120+
caa="$(get_caa_rr_record $caa_node)"
9121+
[[ $caa_node =~ '.'$ ]] || caa_node+="."
9122+
caa_node=${caa_node#*.}
9123+
done
9124+
if [[ -n "$caa" ]]; then
9125+
pr_svrty_good "available"; out " - please check for match with \"Issuer\" above"
9126+
if [[ $(count_lines "$caa") -eq 1 ]]; then
9127+
out ": "
9128+
else
9129+
outln; out "$spaces"
9130+
fi
9131+
while read caa; do
9132+
if [[ -n "$caa" ]]; then
9133+
all_caa+="$caa, "
9134+
fi
9135+
done <<< "$caa"
9136+
all_caa=${all_caa%, } # strip trailing comma
9137+
pr_italic "$(out_row_aligned_max_width "$all_caa" "$indent " $TERM_WIDTH)"
9138+
fileout "${jsonID}${json_postfix}" "OK" "$all_caa"
9139+
else
9140+
pr_svrty_low "not offered"
9141+
fileout "${jsonID}${json_postfix}" "LOW" "--"
9142+
fi
91409143
fi
91419144
outln
91429145

0 commit comments

Comments
 (0)