Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch integration tests to use edge-oriented test data #271

Open
gordom6 opened this issue Nov 19, 2020 · 1 comment
Open

Switch integration tests to use edge-oriented test data #271

gordom6 opened this issue Nov 19, 2020 · 1 comment

Comments

@gordom6
Copy link
Contributor

gordom6 commented Nov 19, 2020

Ran into a discrepancy between the way the integration tests work and the way the back end works.

The test data pipeline outputs nodes and edges separately for Cypress, and as KGTK edge format for the back end. The nodes and edges have the pre-KGTK semantics, where nodes were considered separate (and separately sourced) from the edges they appeared in.

Given this scenario:
edge1 that connects node1, edge has source P0, P1
edge2 that connects node1, edge has source P0, P2

The test data pipeline outputs a single node, the first, with sources P0, P1. Whereas KGTK treats the union of sources of edges involving a node as the node's sources. The latter is the correct interpretation.

Depends on work switching mowgli-etl to only output KGTK. We may want to also switch mowgli-etl to only output edges and not nodes.

@gordom6
Copy link
Contributor Author

gordom6 commented Nov 19, 2020

@stouffers FYI, a long-term issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant