Skip to content

Latest commit

 

History

History
168 lines (111 loc) · 5.85 KB

CONTRIBUTING.md

File metadata and controls

168 lines (111 loc) · 5.85 KB
Raw

Contribution guidelines

Getting in touch

Pull request

To contribute you should clone the 3liz/lizmap-web-client repository into your GitHub account. After adding some changes in a new branch (see Branches and Commits), you should do a pull request in GitHub.

Branches

  • New features are developed in master branch
  • release_X_Y branches are created for each stable version, for example release_3_4 for Lizmap 3.4
  • Starting from January 2021, bug fixes must land on the master branch. To backport to a released branch, either use the backport bot or do the cheery-pick manually. It's your responsibility to check the backport.

Commits

You should create commits in a new branch based on the master branch.

# git checkout -b <your-new-branch> master
# example:

git checkout -b fix-something master
  • Commit messages must be written with care. First line of the message is short and allows a quick comprehension. A description can be written after a line break if more text is needed.
  • Related issues must be written in the commit message. Be aware GitHub can close related issues when using some words: https://help.github.com/articles/closing-issues-via-commit-messages/
  • A keyword can be used to prefix the commit and describe the type of commit, between brackets like [FEATURE] or [BUGFIX]

For example :

[FEATURE] New super feature to make coffea #123456789

This allows the user to request coffea:
* with sugar
* long or regular

Build and install dependencies

Since Lizmap 3.4, the source code in the repository is not usable directly. The application should be "built" first.

If you want to modify then test the code of Lizmap, or if you want to generate zip packages you must install some tools. See below.

If you just want to modify and/or test the docker image of Lizmap (the docker/ directory). See docker/CONTRIBUTING.md.

tools

You need some developer tools in order to build and install dependencies.

Building a zip with Javascript and PHP

  • Run make package in your terminal.
  • You'll have 3 packages in the build directory:
    • lizmap-web-client and lizmap-web-client-X.Y are identical.
    • Each folder has its own zip file too.
    • lizmapdemo is a module for the Lizmap demo.

Building JavaScript only

Requirements

  • Install dependencies :
    • cd assets/
    • npm install

It creates a assets/node_modules/ directory. Don't commit it into the git repository!

Installation

  • Build for production (minified JS files) : npm run build

Don't commit minified JS files into the git repository. They will be built by our continuous integration and added into zip packages that are available on github.

  • Build for development (source mapping, build is executed at every change on a JS file) : npm run watch

Look at webpack documentation for other development options (e.g. live reloading)

Installing PHP dependencies only

Run composer install into the lizmap/ directory.

It will download some packages and install them into lizmap/vendor/. Don't commit this directory into the git repository!

Coding style

PHP

Use php-cs-fixer to follow our coding style in PHP sources. Launch it at the root of the repository.

php-cs-fixer fix

Configuration of php-cs-fixer has been setup into .php-cs.dist.

JavaScript

Please run npm run pretest in assets/ directory and fix errors before any commit.

Issues

Go to https://github.com/3liz/lizmap-web-client/issues and post issues you find.

Testing your changes

Tests is highly recommended for any new commits. Tests can be provided with :

  • End-to-end tests with Cypress
  • PHP Unit tests
  • Manual tests

You can test your changes, or you can launch unit tests, by running some Docker containers. Go into tests/ and read the README.md file. A docker-compose.yml file is provided, launching a full stack of softwares to run Lizmap (nginx, php-fpm, qgis, postgresql...).

You can test with Android browsers in your Ubuntu Desktop thanks to Anbox. For example, you can download a x86 version of Firefox Mobile then install it.

Localization

The locale files (except for en_US language) are stored into the lizmap/app/locales directory. The files are *.properties. You can find documentation about localizing Jelix application here : https://docs.jelix.org/en/manual-1.6/locales.

Locale files for en_US language are stored into modules directly (see locales/ directory into sub-directories of lizmap/modules/).

Only modifications on en_US locales are accepted in Pull Requests.

All other locales are translated with Transifex. So to help us to translate, please go on Transifex:

For core developers, see the repository https://github.com/3liz/lizmap-locales/ and https://github.com/jelix/jelix-langpacks.