Skip to content

Commit 090a9c5

Browse files
author
Adrian Cole
committed
quote more bwplotka/bingo#26
Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 parent aff50fa commit 090a9c5

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.bingo/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ reference as a variable like `$(GOIMPORTS)`.
1111

1212
This differs slightly from the defaults of the Bingo project:
1313
* ENV variable support is not included as this project only uses `make`
14+
* Quotes more in `Variables.mk` for windows per https://github.com/bwplotka/bingo/issues/26

.bingo/Variables.mk

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,23 +21,23 @@ GOIMPORTS := $(GOBIN)/goimports-v0.1.2
2121
$(GOIMPORTS): $(BINGO_DIR)/goimports.mod
2222
@# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
2323
@echo "(re)installing $(GOBIN)/goimports-v0.1.2"
24-
@cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=goimports.mod -o=$(GOBIN)/goimports-v0.1.2 "golang.org/x/tools/cmd/goimports"
24+
@cd "$(BINGO_DIR)" && $(GO) build -mod=mod -modfile=goimports.mod -o="$(GOBIN)/goimports-v0.1.2" "golang.org/x/tools/cmd/goimports"
2525

2626
GOLANGCI_LINT := $(GOBIN)/golangci-lint-v1.40.1
2727
$(GOLANGCI_LINT): $(BINGO_DIR)/golangci-lint.mod
2828
@# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
2929
@echo "(re)installing $(GOBIN)/golangci-lint-v1.40.1"
30-
@cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=golangci-lint.mod -o=$(GOBIN)/golangci-lint-v1.40.1 "github.com/golangci/golangci-lint/cmd/golangci-lint"
30+
@cd "$(BINGO_DIR)" && $(GO) build -mod=mod -modfile=golangci-lint.mod -o="$(GOBIN)/golangci-lint-v1.40.1" "github.com/golangci/golangci-lint/cmd/golangci-lint"
3131

3232
GORELEASER := $(GOBIN)/goreleaser-v0.166.0
3333
$(GORELEASER): $(BINGO_DIR)/goreleaser.mod
3434
@# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
3535
@echo "(re)installing $(GOBIN)/goreleaser-v0.166.0"
36-
@cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=goreleaser.mod -o=$(GOBIN)/goreleaser-v0.166.0 "github.com/goreleaser/goreleaser"
36+
@cd "$(BINGO_DIR)" && $(GO) build -mod=mod -modfile=goreleaser.mod -o="$(GOBIN)/goreleaser-v0.166.0" "github.com/goreleaser/goreleaser"
3737

3838
LICENSER := $(GOBIN)/licenser-v0.6.0
3939
$(LICENSER): $(BINGO_DIR)/licenser.mod
4040
@# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
4141
@echo "(re)installing $(GOBIN)/licenser-v0.6.0"
42-
@cd $(BINGO_DIR) && $(GO) build -mod=mod -modfile=licenser.mod -o=$(GOBIN)/licenser-v0.6.0 "github.com/liamawhite/licenser"
42+
@cd "$(BINGO_DIR)" && $(GO) build -mod=mod -modfile=licenser.mod -o="$(GOBIN)/licenser-v0.6.0" "github.com/liamawhite/licenser"
4343

0 commit comments

Comments
 (0)