Skip to content

Commit 5ba6be4

Browse files
author
Adrian Cole
committed
Fixes compilation break on Windows
This doesn't fix all the tests or make binaries avaiable. It just makes it possible to compile on windows.
1 parent 71d47b3 commit 5ba6be4

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

internal/envoy/procattr.go internal/envoy/procattr_darwin.go

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
// +build !linux
16-
1715
package envoy
1816

1917
import (

internal/envoy/procattr_windows.go

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// Copyright 2021 Tetrate
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
package envoy
16+
17+
import (
18+
"syscall"
19+
)
20+
21+
func sysProcAttr() *syscall.SysProcAttr {
22+
// TODO: We don't use syscall.CREATE_NEW_PROCESS_GROUP because we want external killing of getenvoy to kill the
23+
// spawned process. If we put this in a new process group, that wouldn't happen. Either way this is as yet untested.
24+
return &syscall.SysProcAttr{}
25+
}

0 commit comments

Comments
 (0)