Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: regression in path/filepath test suite #1518

Closed
achille-roussel opened this issue Jun 13, 2023 · 3 comments
Closed

go: regression in path/filepath test suite #1518

achille-roussel opened this issue Jun 13, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@achille-roussel
Copy link
Collaborator

Describe the bug

Running tests for the Go standard path/filepath package is failing on wazero v1.2.0+

To Reproduce

  • clone the Go source code
  • from the root directory of the Go source tree, compile Go: cd src && ./make.bash
  • from the root directory of the Go source tree, run the following command :
$ GOWASIRUNTIME=wazero GOROOT=$PWD GOOS=wasip1 GOARCH=wasm PATH=$PWD/misc/wasm:$PATH ./bin/go test ./src/path/filepath
--- FAIL: TestWalkSymlinkRoot (0.00s)
    --- FAIL: TestWalkSymlinkRoot/double_link_with_slash (0.00s)
        path_test.go:916: `/var/folders/qc/zv1mt0j11sscgjygfx47nxlm0000gn/T/TestWalkSymlinkRoot2033040065/001/linklink/`: Lrw-------
        path_test.go:925: Walk(`/var/folders/qc/zv1mt0j11sscgjygfx47nxlm0000gn/T/TestWalkSymlinkRoot2033040065/001/linklink/`) visited [`/var/folders/qc/zv1mt0j11sscgjygfx47nxlm0000gn/T/TestWalkSymlinkRoot2033040065/001/linklink`]; want [`/var/folders/qc/zv1mt0j11sscgjygfx47nxlm0000gn/T/TestWalkSymlinkRoot2033040065/001/linklink` `/var/folders/qc/zv1mt0j11sscgjygfx47nxlm0000gn/T/TestWalkSymlinkRoot2033040065/001/linklink/foo`]
FAIL
FAIL	path/filepath	0.322s
FAIL

Expected behavior

The test should pass.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the relevant information):

  • Go version: v1.20.4
  • wazero Version: v1.2.0
  • Host architecture: darwin/arm64
  • Runtime mode: compiler
@achille-roussel achille-roussel added the bug Something isn't working label Jun 13, 2023
@evacchi
Copy link
Contributor

evacchi commented Jun 14, 2023

If I understood correctly, @chriso noted this is a behavioral issue of macOS and the test is being skipped in the Go codebase unless it runs on Linux

see also golang/go#59586 (comment)

@evacchi
Copy link
Contributor

evacchi commented Jul 7, 2023

I think we can close this?

@chriso
Copy link
Contributor

chriso commented Jul 7, 2023

+1 to closing. We noticed that wasi-go has the same issue on macOS. Based on the discussions in golang/go#59586, we're confident it's an OS bug rather than an issue with the WASI layer.

@achille-roussel achille-roussel closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants