Benchmarking test: commitment calculation

[bitcartel]

Just wanted to check this is the intended behaviour for the benchmarking test in batch mode.

randomx_calculate_commitment is invoked using the blockTemplate buffer containing the new nonce, and the hash value which was computed for the old nonce.

if (batch) {
	nonce = atomicNonce.fetch_add(1);
}
store32(noncePtr, nonce);
(batch ? randomx_calculate_hash_next : randomx_calculate_hash)(vm, blockTemplate, sizeof(blockTemplate), &hash);
if (commit) {
	randomx_calculate_commitment(blockTemplate, sizeof(blockTemplate), &hash, &hash);
}

https://github.com/tevador/RandomX/blob/master/src/tests/benchmark.cpp#L143

[SChernykh]

@tevador It seems to be a bug in the benchmarking code.

[tevador]

RandomX/src/tests/benchmark.cpp

Line 298 in 102f8ac

//TODO: support batch mode with commitments

Not a bug, just not implemented.