Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow save method to write unknown objects if they already have an _id property #440

Closed
carsonfarmer opened this issue Sep 18, 2020 · 1 comment
Closed

Allow save method to write unknown objects if they already have an _id property #440

carsonfarmer opened this issue Sep 18, 2020 · 1 comment
Assignees
@carsonfarmer
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Sprint 45

Comments

@carsonfarmer
Copy link
Member

Right now, calling save on an instance that doesn't already exist throws an error. But this need not really be the case if that instance has a valid _id field (which we can check as we do all "saved" instances. Allowing save on unknown instances is useful when we need to create or update an instance, and don't know ahead of time if it will already exist.
@carsonfarmer carsonfarmer added enhancement New feature or request good first issue Good for newcomers labels Sep 18, 2020
@carsonfarmer carsonfarmer added this to the Sprint 45 milestone Sep 18, 2020
@carsonfarmer carsonfarmer self-assigned this Sep 18, 2020
@carsonfarmer carsonfarmer mentioned this issue Oct 16, 2020
Merged
@carsonfarmer
Copy link
Member Author

Fixed with #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carsonfarmer carsonfarmer

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Sprint 45
Development

No branches or pull requests
1 participant
@carsonfarmer