tests should not depend on external apis being up

[nicolasochem]

CI tests appear broken now. Tests should run in isolation IMO. Have you considered recording and replaying API calls from external RPC services (RPC, tzstats, tzkt), for example like this:

https://www.mock-server.com/proxy/record_and_replay.html

[nicolasochem]

or this https://dev.to/meeshkan/create-a-mock-server-for-any-rest-api-592l

[vkresch]

@nicolasochem thanks for reporting. I created a PR as a hotfix. The reason for the current error is the recent removal of the https://api.carthage.tzkt.io/v1/ domain name.

IMO it's always good to test the trd functions against the real API so that the regression tests are always up to date and detect compatibility issues between trd and the API on which it depends. When a test fails it means either the test or the function which it tests needs to be fixed which is a good process for the improvement of trd. Imagine for example the tzkt API gets removed and the trd tests report only passed tests. Let's hear other opinions, too.

[jdsika]

Using recorded api calls is on my wish list for over 1 year now - Viktor has just started and will go towards this task! Important, thank you for also noticing :)