-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Typescript #962
Comments
Might as well as use vite |
Damn that's a gigantic assignment. Might atleast double the amount of lines in this project... |
I manage to get it to work, we just need to add typing now. |
one big problem is plugins doesn't work correctly... hmm.. |
Migrating to ESM and TS would definitely be awesome, though it's indeed a lot of work 😅 The best way forward would probably be to introduce ts along js, then migrate file by file until everything is done |
Very good idea |
I also propose that changes be merged on a separate experimental branch, to avoid breaking stuff for the end user |
Lmao, looks like xhayper gave up on this? I am up for the task, although I don't have a lot of free time, so it may take a while :^) |
yeah i gave up on this, got another project going on, sorry. |
Calling everyone interested in the typescript re-write to discuss over at my fork. https://github.com/ArjixWasTaken/youtube-music-ts/discussions/1 PS: If you actually run my fork, it won't run any plugins and such, that is because of an on-going issue I have with |
@th-ch maybe pin this issue? that way more people would see it and join in on the effort |
Migration to TypeScript is complete! (#1235) |
Will be doing this
Please assign me to this.
The text was updated successfully, but these errors were encountered: