Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Typescript #962

Closed
xhayper opened this issue Jan 12, 2023 · 13 comments · Fixed by #1235
Closed

Migration to Typescript #962

xhayper opened this issue Jan 12, 2023 · 13 comments · Fixed by #1235
Labels
fix-available A fix to the issue is available in a new version

Comments

@xhayper
Copy link
Contributor

xhayper commented Jan 12, 2023

Will be doing this
Please assign me to this.

@Zo-Bro-23
Copy link
Contributor

@th-ch?

@xhayper
Copy link
Contributor Author

xhayper commented Jan 12, 2023

Might as well as use vite

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 12, 2023

Damn that's a gigantic assignment.

Might atleast double the amount of lines in this project...

@xhayper
Copy link
Contributor Author

xhayper commented Jan 12, 2023

I manage to get it to work, we just need to add typing now.
https://github.com/xhayper/youtube-music/tree/patch-2

@xhayper
Copy link
Contributor Author

xhayper commented Jan 12, 2023

one big problem is plugins doesn't work correctly... hmm..

@th-ch
Copy link
Owner

th-ch commented Jan 15, 2023

Migrating to ESM and TS would definitely be awesome, though it's indeed a lot of work 😅 The best way forward would probably be to introduce ts along js, then migrate file by file until everything is done

@xhayper
Copy link
Contributor Author

xhayper commented Jan 15, 2023

Very good idea

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 15, 2023

I also propose that changes be merged on a separate experimental branch, to avoid breaking stuff for the end user
(which will probably happen)

@ArjixWasTaken
Copy link
Contributor

Lmao, looks like xhayper gave up on this?

I am up for the task, although I don't have a lot of free time, so it may take a while :^)

@xhayper
Copy link
Contributor Author

xhayper commented Jul 21, 2023

yeah i gave up on this, got another project going on, sorry.

@ArjixWasTaken
Copy link
Contributor

ArjixWasTaken commented Jul 26, 2023

Calling everyone interested in the typescript re-write to discuss over at my fork.

https://github.com/ArjixWasTaken/youtube-music-ts/discussions/1

PS: If you actually run my fork, it won't run any plugins and such, that is because of an on-going issue I have with electron-vite, so I am focusing all my efforts on the type system until that issue is fixed.

@ArjixWasTaken
Copy link
Contributor

@th-ch maybe pin this issue?

that way more people would see it and join in on the effort

@JellyBrick
Copy link
Collaborator

Migration to TypeScript is complete! (#1235)

@JellyBrick JellyBrick added the fix-available A fix to the issue is available in a new version label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-available A fix to the issue is available in a new version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants