Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use Thanos v0.20.1 #25

Open
gmfrasca opened this issue May 18, 2021 · 1 comment
Open

Refactor to use Thanos v0.20.1 #25

gmfrasca opened this issue May 18, 2021 · 1 comment

Comments

@gmfrasca
Copy link
Contributor

gmfrasca commented May 18, 2021

We would like to have the thanos dependency's version incremented v0.20.1 (and conflicts stemming from that resolved). This version of the thanos code has new features, one of which that we're particularly interested in is the ability to use self-signed certificates for the storeapi grpc connection.

Unfortunately it's a relatively large jump, (from v0.13.1), and it looks like a simple version bump in go.mod throws a bunch of dependency conflicts or build errors, so it appears to be non-trivial/a bit more complicated than that.

@anishasthana
Copy link
Contributor

When we took a stab at upgrading it, we ended up with the following https://github.com/anishasthana/obslytics/tree/update_dependencies. We have not been able to get around one of the dependency failures. Pinning gnostic to v0.4.0 resulted in another import failing as one of the other modules requires v0.5.1 or higher.

> go mod tidy
go: finding module for package github.com/googleapis/gnostic/openapiv2
github.com/thanos-community/obslytics/pkg/series/promread imports
        github.com/prometheus/prometheus/storage/remote imports
        github.com/prometheus/prometheus/config tested by
        github.com/prometheus/prometheus/config.test imports
        github.com/prometheus/prometheus/discovery/kubernetes tested by
        github.com/prometheus/prometheus/discovery/kubernetes.test imports
        k8s.io/client-go/kubernetes/fake imports
        k8s.io/client-go/testing imports
        k8s.io/apimachinery/pkg/util/strategicpatch tested by
        k8s.io/apimachinery/pkg/util/strategicpatch.test imports
        k8s.io/apimachinery/pkg/util/strategicpatch/testing imports
        github.com/googleapis/gnostic/openapiv2: module github.com/googleapis/gnostic@latest found (v0.5.5, replaced by github.com/googleapis/gnostic@v0.4.0), but does not contain package github.com/googleapis/gnostic/openapiv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants