fix creds

alanprot · alanprot · commit 0419db6d1d98 · 2024-06-10T11:14:17.000-07:00
Signed-off-by: alanprot &lt;alanprot@gmail.com&gt;
diff --git a/pkg/clientconfig/http.go b/pkg/clientconfig/http.go
@@ -176,9 +176,9 @@ func NewRoundTripperFromConfig(cfg config_util.HTTPClientConfig, transportConfig
 
 		if cfg.BasicAuth != nil {
 			// TODO(yeya24): expose UsernameFile as a config.
-			if len(cfg.BasicAuth.PasswordFile) >= 0 {
+			if len(cfg.BasicAuth.PasswordFile) > 0 {
 				rt = config_util.NewBasicAuthRoundTripper(config_util.NewInlineSecret(cfg.BasicAuth.Username), config_util.NewInlineSecret(cfg.BasicAuth.PasswordFile), rt)
-			} else if len(cfg.BasicAuth.Password) >= 0 {
+			} else if len(cfg.BasicAuth.Password) > 0 {
 				rt = config_util.NewBasicAuthRoundTripper(config_util.NewInlineSecret(cfg.BasicAuth.Username), config_util.NewInlineSecret(string(cfg.BasicAuth.Password)), rt)
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -176,9 +176,9 @@ func NewRoundTripperFromConfig(cfg config_util.HTTPClientConfig, transportConfig`
`176`	`176`
`177`	`177`	`if cfg.BasicAuth != nil {`
`178`	`178`	`// TODO(yeya24): expose UsernameFile as a config.`
`179`		`- if len(cfg.BasicAuth.PasswordFile) >= 0 {`
	`179`	`+ if len(cfg.BasicAuth.PasswordFile) > 0 {`
`180`	`180`	`rt = config_util.NewBasicAuthRoundTripper(config_util.NewInlineSecret(cfg.BasicAuth.Username), config_util.NewInlineSecret(cfg.BasicAuth.PasswordFile), rt)`
`181`		`- } else if len(cfg.BasicAuth.Password) >= 0 {`
	`181`	`+ } else if len(cfg.BasicAuth.Password) > 0 {`
`182`	`182`	`rt = config_util.NewBasicAuthRoundTripper(config_util.NewInlineSecret(cfg.BasicAuth.Username), config_util.NewInlineSecret(string(cfg.BasicAuth.Password)), rt)`
`183`	`183`	`}`
`184`	`184`	`}`