website: Netlify preview and master are flaky 90% time.

[bwplotka]

Netlify preview on PR is not required if it does not touch website or docs. However if it touches, we have this issue: Netlify deployments are flaky. The flakiness looks like this:

11:55:03 AM: Error: Error building site: failed to render pages: render of "page" failed: execute of template failed: html/template:proposal/single.html:5:28: no such template "_default/sidemenu.html"

If you see something like this and you want see preview, ask maintainer for retry. We assume this is flakiness as after couple (1-10) retries it works. Netlify was notified but they don't see any issue on their side. ): Worth to try dig more and get into this why, e.g by using their image locally, but the fact that it sometimes works sometimes not (I guess - depending on what container/node it sits on) is highly demotivating.

AC:

• Eliminate flakiness.
• Mark netlify preview deploy on PR as required

[bwplotka]

This is actually reproducible offline from time to time - so it is our issue. Hopefully fixed by #1105

[bwplotka]

OK, it seems like the issue was on hugo side. Looks like for (IMO) no reason, moving sidemenu.html from layouts/_default/ to layouts/partials/_default and using {{ partial .. instead of {{ template fixed the issue, but who knows why 🤷‍♂️

Literally found that by accident. Anyway, netlify now works like a charm, no flakiness!