Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objstore : implement Aliyun OSS #1221

Closed
ghost opened this issue Jun 5, 2019 · 8 comments
Closed

objstore : implement Aliyun OSS #1221

ghost opened this issue Jun 5, 2019 · 8 comments

Comments

@ghost
Copy link

ghost commented Jun 5, 2019

Hello , everyone . I pulled the code of thanos and built it a couple of days before , it is a awesome
project working with prometheus . But in my company env , It is much popular with Aliyun OSS than GCS/S3 . As you know , thanos is not supported Aliyun OSS right now , so I implement objstore integrated with Aliyun OSS .
Could I push the code in repository ?

@yeya24
Copy link
Contributor

yeya24 commented Jun 5, 2019

Thanks! @shaulboozhiao Please go ahead and make a PR directly 😄

@jojohappy
Copy link
Member

PR is welcome! Thanks!

@bwplotka
Copy link
Member

bwplotka commented Jun 5, 2019

Yes, we are happy to take PR. Remember about all the steps mentioned here: https://thanos.io/storage.md/#how-to-add-a-new-client

Thanks @shaulboozhiao !

@ghost
Copy link
Author

ghost commented Jun 6, 2019

@bwplotka @jojohappy @yeya24 I will work on step 3 ~ step 7 following the Object Storage guide .

@ghost
Copy link
Author

ghost commented Jun 8, 2019

#1234 PR is submitted , Could some one take a review , thanks ~~

@gagado
Copy link

gagado commented Jul 31, 2019

@shaulboozhiao hi,now,i want use thanos with aliyun-oss, now can use?,thank you.

@ghost
Copy link
Author

ghost commented Aug 2, 2019

@gagado This feature is not merged into master trunk , but the code is available . You can use in test env , maybe .

@bwplotka
Copy link
Member

bwplotka commented Nov 1, 2019

Hello! Thanks to @wujinhu we now have Aliyun implementation: https://thanos.io/storage.md/#aliyun-oss Feel free to use it and give us feedback (:

It is available on the master, and should be part of 0.9 release. (:

@bwplotka bwplotka closed this as completed Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants