Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Web Identity providers for IAM credentials for AWS EKS #1494

Closed
barryib opened this issue Sep 5, 2019 · 4 comments · Fixed by #2033
Closed

Support Web Identity providers for IAM credentials for AWS EKS #1494

barryib opened this issue Sep 5, 2019 · 4 comments · Fixed by #2033

Comments

@barryib
Copy link

barryib commented Sep 5, 2019

Add support for Web Identity providers for IAM credentials for AWS EKS (IAM Roles for Service Accounts) https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html

I think this related to minio sdk, but I opening it here also to track this proposal.

@harshavardhana
Copy link

@evq
Copy link

evq commented Dec 31, 2019

When using the minio-go revision from minio/minio-go#1183 this just works, so once that PR is merged I believe a minio-go version bump will be needed.

[user@work:~/source/thanos]% git diff
diff --git go.mod go.mod
index 171dd718..fa93a0d1 100644
--- go.mod
+++ go.mod
@@ -112,6 +112,7 @@ require (
 replace (
        // Mitigation for: https://github.com/Azure/go-autorest/issues/414
        github.com/Azure/go-autorest => github.com/Azure/go-autorest v12.3.0+incompatible
+       github.com/minio/minio-go/v6 => github.com/saracen/minio-go/v6 v6.0.41-0.20191205161654-99323bc99b57
        k8s.io/api => k8s.io/api v0.0.0-20190620084959-7cf5895f2711
        k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.0.0-20190620085554-14e95df34f1f
        k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20190612205821-1799e75a0719

@bwplotka
Copy link
Member

bwplotka commented Jan 2, 2020

Thanks for update 👍 STGM @evq

@robcoward
Copy link
Contributor

https://github.com/minio/minio-go/releases/tag/v6.0.45 has just been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants