Web route prefix is not applied on debug endpoints.

[yeya24]

In Prometheus, if the web external path is set, then all Prometheus routes will be updated. There is a good example here https://www.robustperception.io/using-external-urls-and-proxies-with-prometheus

You should be aware that with this external URL, the /prometheus/ path prefix will be required for all HTTP access to Prometheus. 

The /metrics will be on http://localhost:9090/prometheus/metrics for example.

However, in thanos, if web route prefix is set to /thanos, only /api/v1 endpoints will be updated to /thanos/api/v1. But other endpoints like /metrics, still serve on /metrics, we should add web route prefix to these endpoints as well.

AC:

• Endpoints like /metrics or /-/ready can work with web route prefix just like Prometheus.

[fengzixu]

/assign @fengzixu

[bwplotka]

Fixed on relase branch, v0.12.1 should have it

[yeya24]

This is not done. #2489 only fixes the problem of duplicate registering the web route prefix. This issue more focused on handling some other endpoints with web route prefix. Such as /metrics and /-/ready, to be consistent with the endpoints in Prometheus.

[bwplotka]

Sorry, you are right, I confused things. Thanks @yeya24 !

[yeya24]

No worries. @bwplotka Feel free to edit the issue description, if it is not clear to you. Maybe we should update the title?

[ranjithkumar007]

@fengzixu are you working on this issue?

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

Valid #2524

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[ranjithkumar007]

Hi @stalebot, I will update this.

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[ranjithkumar007]

calm down @stale-bot

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[yeya24]

This pr should be review #2524, just need another 👁️ to take a look.

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

Need another review.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

Still valid.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗