-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web route prefix is not applied on debug endpoints. #2486
Comments
/assign @fengzixu |
Fixed on relase branch, v0.12.1 should have it |
This is not done. #2489 only fixes the problem of duplicate registering the web route prefix. This issue more focused on handling some other endpoints with web route prefix. Such as |
Sorry, you are right, I confused things. Thanks @yeya24 ! |
No worries. @bwplotka Feel free to edit the issue description, if it is not clear to you. Maybe we should update the title? |
@fengzixu are you working on this issue? |
Hello 👋 Looks like there was no activity on this issue for last 30 days. |
Valid #2524 |
Hello 👋 Looks like there was no activity on this issue for last 30 days. |
Hi @stalebot, I will update this. |
Hello 👋 Looks like there was no activity on this issue for last 30 days. |
calm down @stale-bot |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
This pr should be review #2524, just need another 👁️ to take a look. |
Hello 👋 Looks like there was no activity on this issue for last 30 days. |
Need another review. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Still valid. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
In Prometheus, if the web external path is set, then all Prometheus routes will be updated. There is a good example here https://www.robustperception.io/using-external-urls-and-proxies-with-prometheus
However, in thanos, if web route prefix is set to
/thanos
, only/api/v1
endpoints will be updated to/thanos/api/v1
. But other endpoints like/metrics
, still serve on/metrics
, we should add web route prefix to these endpoints as well.AC:
/metrics
or/-/ready
can work with web route prefix just like Prometheus.The text was updated successfully, but these errors were encountered: