Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master (future v0.13.0): Thanos receive leaks goroutines. #2594

Closed
bwplotka opened this issue May 12, 2020 · 4 comments
Closed

master (future v0.13.0): Thanos receive leaks goroutines. #2594

bwplotka opened this issue May 12, 2020 · 4 comments
Labels

Comments

@bwplotka
Copy link
Member

We are chasing a bug that causes receiver to slowly leak memory. 💩

image

Introduced most likely by any of #2564, #2563, #2557, #2012 or Go 1.14 upgrade.

cc @brancz @squat

Nothing obvious with leaktest: #2593

Let's grab some go routine dump.

@bwplotka bwplotka added the bug label May 13, 2020
@bwplotka
Copy link
Member Author

Looks like it was uncutted WAL because of failed migration (we had unused tenants left behind).

@bwplotka
Copy link
Member Author

image

@GiedriusS
Copy link
Member

So we can close this, right? :P

@bwplotka
Copy link
Member Author

Yes, sorry (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants