Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Viewer: Show size of the blocks in the UI #3221

Closed
onprem opened this issue Sep 24, 2020 · 15 comments
Closed

Block Viewer: Show size of the blocks in the UI #3221

onprem opened this issue Sep 24, 2020 · 15 comments

Comments

@onprem
Copy link
Member

onprem commented Sep 24, 2020

The size of a block is a useful metric. We can show things like the overall size of a block, the size of it's index, the total size occupied by all blocks, etc. in the Block Viewer itself.

@aribalam
Copy link
Contributor

I see that Prometheus has an API exposed to query currently stored TSDB Blocks (via /api/query/v1/blocks). But I am unable to find details of it in the Prometheus or Thanos docs. I am guessing the above required data will be queried using that API?
Is there any relevant docs or resources where I can find details of such an API.

@roidelapluie
Copy link

Note that recently Prometheus BlockReader gained Size() function.

@bwplotka
Copy link
Member

I see that Prometheus has an API exposed to query currently stored TSDB Blocks (via /api/query/v1/blocks). But I am unable to find details of it in the Prometheus or Thanos docs. I am guessing the above required data will be queried using that API?
Is there any relevant docs or resources where I can find details of such an API.

We have other APIs for this and yes, it should be better documented - only block viewer is using it.

Note that recently Prometheus BlockReader gained Size() function.

This is great but not very helpful for this issue, as we store all blocks in object storage (:

@roidelapluie
Copy link

I see that Prometheus has an API exposed to query currently stored TSDB Blocks (via /api/query/v1/blocks). But I am unable to find details of it in the Prometheus or Thanos docs. I am guessing the above required data will be queried using that API?
Is there any relevant docs or resources where I can find details of such an API.

We have other APIs for this and yes, it should be better documented - only block viewer is using it.

Note that recently Prometheus BlockReader gained Size() function.

This is great but not very helpful for this issue, as we store all blocks in object storage (:

object storage does not implement the BlockReader interface?

@bwplotka
Copy link
Member

Not directly.

@stale
Copy link

stale bot commented Dec 31, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Dec 31, 2020
@roidelapluie
Copy link

yes

@stale stale bot removed the stale label Jan 1, 2021
@zerefwayne
Copy link

Hi @roidelapluie @prmsrswt I would like to take this up if it's still unresolved.

@stale
Copy link

stale bot commented Jun 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added stale and removed stale labels Jun 2, 2021
@stale
Copy link

stale bot commented Aug 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 2, 2021
@onprem onprem removed the stale label Aug 6, 2021
@stale
Copy link

stale bot commented Oct 11, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Oct 11, 2021
@onprem onprem removed the stale label Oct 25, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Mar 2, 2022
@matej-g matej-g reopened this Mar 3, 2022
@stale stale bot removed the stale label Mar 3, 2022
@stale
Copy link

stale bot commented May 2, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 2, 2022
@GiedriusS GiedriusS added dont-go-stale Label for important issues which tells the stalebot not to close them and removed stale labels May 2, 2022
@douglascamata
Copy link
Contributor

Closing this as done with PR #7233, related to #7205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants