-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website --web.enable-admin-api confusion #3278
Comments
Right, it is confusing and I believe this flag is not needed. Prometheus external labels are fetched from |
Not really, we use flags endpoint as well. |
But overall, let's double check we added this piece of doc and requirement at the very start of Thanos, I suppose for snapshot purposes, although we don't use it now on sidecar. So there is some chances that this flag is not needed at all. (: |
Thank you both! :-) I found the reason the statement was added. Prior to #1354 #1355, the ExternalLabels func incorrectly returned error The only func I could find that calls an admin api is the Snapshot func in promclient. But, as was stated, I couldn't find where that func is currently used. |
@ericdstein Thanks for checking. I think this snapshot is outdated and not used anymore. It is safe to remove that. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Latest documents still describe enabling of |
Thanos, Prometheus and Golang version used:
Thanos: v0.15
Prometheus: 2.21
In multiple places, including the sidecar docs, I have seen the following statement.
It doesn't appear, however, that this flag controls access to metadata. Instead, it appears to control access to perform certain admin tasks and thus may only be required if using the Sidecar to send data to object storage. If one were to just use Query, is this flag required to be set for Prometheus?
The text was updated successfully, but these errors were encountered: