Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: Use injectLabels optimizations #3571

Closed
bwplotka opened this issue Dec 11, 2020 · 8 comments
Closed

sidecar: Use injectLabels optimizations #3571

bwplotka opened this issue Dec 11, 2020 · 8 comments

Comments

@bwplotka
Copy link
Member

AC:

  • Use the same optimization as here but in the sidecar.

The nontrivial thing is to parse the map in an ordered fashion so labels are sorted:
image

lset := make([]labelpb.ZLabel, 0, len(lbm)+len(externalLabels))

@Biswajitghosh98
Copy link
Contributor

Hi @bwplotka!
I was looking forward to be a part of Thanos, and I'd like to start with this issue

@stale
Copy link

stale bot commented Feb 12, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Feb 12, 2021
@kakkoyun
Copy link
Member

Still valid.

@stale stale bot removed the stale label Feb 12, 2021
@longngn
Copy link
Contributor

longngn commented Feb 17, 2021

@bwplotka I'm looking into this issue. However, I stumbles across some problems:

  1. Does Prometheus /api/v1/series API guarantee to return sorted labels?
  2. Even if the API returns sorted labels, JSON spec and encoding/json package don't guarantee object ordering (see more: encoding/json: no way to preserve the order of map keys golang/go#27179)

@stale
Copy link

stale bot commented Apr 18, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Apr 18, 2021
@stale
Copy link

stale bot commented Jun 3, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Jun 3, 2021
@kakkoyun kakkoyun removed the stale label Jun 11, 2021
@kakkoyun kakkoyun reopened this Jun 11, 2021
@stale
Copy link

stale bot commented Aug 13, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 13, 2021
@stale
Copy link

stale bot commented Aug 28, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants