Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone aware replication #3820

Open
brancz opened this issue Feb 22, 2021 · 11 comments
Open

Zone aware replication #3820

brancz opened this issue Feb 22, 2021 · 11 comments

Comments

@brancz
Copy link
Member

brancz commented Feb 22, 2021

Is your proposal related to a problem?

Allow not just replication factor and quorum to be a deciding factor, but also that this quorum must be across availability zones.

Describe the solution you'd like

Make Thanos aware of the availability zones receive nodes are in, and allow quorum to pass if and only if ceil(replication-factor/2) availability zones were successfully replicated to.

Describe alternatives you've considered

Leaving as is, or not using Thanos. Leaving as is does not tolerate an entire zone outage though, which is not included in most cloud provider's SLOs (as in cloud providers say, that there is nothing wrong with an entire availability zone being unavailable if the rest works).

@thanos-io/thanos-maintainers

@kakkoyun
Copy link
Member

We could immediately benefit from it in our setup. We have been planning to support multi-cluster deployments.

@stale
Copy link

stale bot commented Jun 3, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 3, 2021
@kakkoyun
Copy link
Member

kakkoyun commented Jun 3, 2021

Still valid.

@stale stale bot removed the stale label Jun 3, 2021
@stale
Copy link

stale bot commented Aug 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Aug 2, 2021
@GiedriusS GiedriusS removed the stale label Aug 2, 2021
@stale
Copy link

stale bot commented Oct 11, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Oct 11, 2021
@stale
Copy link

stale bot commented Oct 30, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@kakkoyun kakkoyun removed the stale label Nov 18, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Mar 2, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Apr 17, 2022
@GiedriusS GiedriusS reopened this Apr 17, 2022
@stale stale bot removed the stale label Apr 17, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@singularitatem
Copy link

+1, multi-az is a highly available requirement for many companies

@GiedriusS
Copy link
Member

This has been implemented already, I think: https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants