Stop uploading debug meta files to obj store

[yeya24]

Is your proposal related to a problem?

(Write your answer here.)

As agreed in one previous community meeting, we decided to remove the step of uploading debug meta files because seems it is hardly used.

@thanos-io/thanos-maintainers

Describe the solution you'd like

Remove step

thanos/pkg/block/block.go

Lines 106 to 108 in 12c826a

	if err := bkt.Upload(ctx, path.Join(DebugMetas, fmt.Sprintf("%s.json", id)), strings.NewReader(metaEncoded.String())); err != nil {
	return cleanUp(logger, bkt, id, errors.Wrap(err, "upload debug meta file"))
	}

and related tests code.

[hitanshu-mehta]

Can i work on this issue?

[bwplotka]

Yes please @hitanshu-mehta !

[pracucci]

/cc @pstibrany

[GiedriusS]

Maybe we should also remove whatever already meta files exist in the bucket already? #3397

[pstibrany]

I have found these files useful when tracking down history of some blocks during our data conversion. I would weakly prefer to keep them, as the overhead seems tiny.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[kakkoyun]

Still valid.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

I am wondering if this issue is still valid or not. There was a pr before but looks like we didn't reach an agreement.

[pstibrany]

I think I was the only one for keeping the debug meta files. As I haven't had any use for them in last ~1year and instead suffered from trying to delete lots of them from object store, I am fine with getting rid of them.

(I hope my previous weak preference to keep them isn't what stalled the work here.)

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

Still valid

[r0mdau]

I tried something, kudos to your work @hitanshu-mehta . I was trying to build thanos using this issue as example. I thought maybe it can helps.