Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: Use Prometheus v2.2+ /api/v1/status/flags to ensure sane configuration #405

Closed
bwplotka opened this issue Jul 3, 2018 · 1 comment · Fixed by #838
Closed

sidecar: Use Prometheus v2.2+ /api/v1/status/flags to ensure sane configuration #405

bwplotka opened this issue Jul 3, 2018 · 1 comment · Fixed by #838

Comments

@bwplotka
Copy link
Member

bwplotka commented Jul 3, 2018

This will help to immediately find:

  • if the sidecar tsdb.path is correct
  • if local compaction is enabled or not.
@bwplotka bwplotka changed the title Use Prometheus v2.2+ /api/v1/status/flags to ensure sane configuration sidecar: Use Prometheus v2.2+ /api/v1/status/flags to ensure sane configuration Jul 3, 2018
@domgreen
Copy link
Contributor

domgreen commented Jul 5, 2018

From Slack, compaction will begin if min duration is smaller than max.

brancz
@domgreen we can ask the prometheus server for all the flags it's running with and make the sidecar exit if 

`--storage.tsdb.min-block-duration != --storage.tsdb.max-block-duration`


brancz
if they min duration is smaller than max duration prometheus will attempt compaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants