Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules: support external-label matcher. [Feature Request] #4812

Closed
hanjm opened this issue Oct 29, 2021 · 6 comments
Closed

Rules: support external-label matcher. [Feature Request] #4812

hanjm opened this issue Oct 29, 2021 · 6 comments

Comments

@hanjm
Copy link
Member

hanjm commented Oct 29, 2021

Is your proposal related to a problem?

In sidecar mode, fanout rules api may response lots of rules. Could we support external-label based matcher, a bit like grafana?
image

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@hanjm hanjm changed the title Rules: support label matcher. [Feature Request] Rules: support external-label matcher. [Feature Request] Oct 29, 2021
@yeya24
Copy link
Contributor

yeya24 commented Oct 29, 2021

It would be good to support this in Prometheus first. I think this makes sense for example in multi tenant mode

@hanjm
Copy link
Member Author

hanjm commented Oct 30, 2021

It would be good to support this in Prometheus first. I think this makes sense for example in multi tenant mode

I make a issue in Prometheus just now.
Yeah, in multi tenant mode, prom-label-proxy can be auto inject tenant_id matcher.

@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@hanjm
Copy link
Member Author

hanjm commented Jan 9, 2022

/valid

@stale
Copy link

stale bot commented Apr 17, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Apr 17, 2022
@stale
Copy link

stale bot commented May 1, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants