Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar/compact/store/receiver - Filesystem direcoty delimiter probably doesn't work on Windows #5380

Open
jademcosta opened this issue May 24, 2022 · 2 comments
Labels

Comments

@jademcosta
Copy link
Contributor

jademcosta commented May 24, 2022

Thanos 0.26.0:

Object Storage Provider: Filesystem

What happened: It seems Thanos has a directory delimiter on objstore package. This var is used on several places, including the filesystem bucket (here)[https://github.com/thanos-io/thanos/blob/dd77331f6b7c749ef95480da08ea22765a69bd0c/pkg/objstore/filesystem/filesystem.go#L88].

What you expected to happen:
Any function that uses this delimiter will not work on Windows using the filesystem storage, as directories delimiters are backslashes. Examples are the Iter function.

As the filesystem seems to be created as an experimental bucket, I don't know if this bug is relevant or not, (I mentioned it on a PR) so feel free to just close it in case it is not important. I also don't know if Thanos is supposed to support running on Windows machines. (Windows is mentioned here but I don't know if it is intentional or not)

The bug is pretty obvious so I didn't reproduced it.

@jademcosta
Copy link
Contributor Author

As requested on the docs, I'm pinging @bwplotka (as you're listed as filesystem bucket maintainer)

@stale
Copy link

stale bot commented Jul 31, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant