Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series limits are not effective in Thanos Store #5733

Closed
GiedriusS opened this issue Sep 27, 2022 · 1 comment · Fixed by #5801
Closed

Series limits are not effective in Thanos Store #5733

GiedriusS opened this issue Sep 27, 2022 · 1 comment · Fixed by #5801

Comments

@GiedriusS
Copy link
Member

Is your proposal related to a problem?

We want to limit queries so that they wouldn't try to download millions of series. However, our current limits are only applied after fetching postings. This is because to find out, for example, the number of matching series, you need to perform intersection on postings depending on the given matchers. To have a practical limit here, Thanos Store might possibly download gigabytes of data.

Describe the solution you'd like

Add a byte limit for fetched postings in Thanos Store.

Describe alternatives you've considered

I don't think there are any alternatives here? 🤔

@matej-g
Copy link
Collaborator

matej-g commented Sep 27, 2022

This might be of interest @saswatamcode @douglascamata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants