-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quickstart.sh assigns wrong env variable to S3 secret key #6565
Comments
Hello @scaleoutsean I hope this message finds you well. I'm excited to introduce myself as a new member of the Thanos community. I'm eager to contribute to the organization and help enhance the project. If possible, could you please consider assigning me this issue , I am also open to any guidance or feedback you can provide during the process. |
Thanks for the report @scaleoutsean! And thank you @Vanshikav123, please take it away! This should be straightforward 🙂. |
Thank you @matej-g for assigning me this issue . It would be great help if @scaleoutsean provide me some more information regarding this issue. |
@Vanshikav123 I think the issue is quite straightforward - there is mistake in the parameter name, the line that was reported above needs to changed to:
|
Thank you @matej-g I have made the changes on my way to push it |
Fixed by #6628 |
Thanos version used: latest
Object Storage Provider: S3
What happened: incorrect configuration stored in data/bucket.yaml
What you expected to happen: correct configuration stored
How to reproduce it (as minimally and precisely as possible): modify quickstart.sh and run it
The offending line is here. It should assign
MINIO_ROOT_PASSWORD
.thanos/scripts/quickstart.sh
Line 44 in a817dbf
I'd submit a PR but there's too much digital paperwork here.
The text was updated successfully, but these errors were encountered: