Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart.sh assigns wrong env variable to S3 secret key #6565

Closed
scaleoutsean opened this issue Jul 27, 2023 · 6 comments
Closed

quickstart.sh assigns wrong env variable to S3 secret key #6565

scaleoutsean opened this issue Jul 27, 2023 · 6 comments
Assignees

Comments

@scaleoutsean
Copy link

Thanos version used: latest

Object Storage Provider: S3

What happened: incorrect configuration stored in data/bucket.yaml

What you expected to happen: correct configuration stored

How to reproduce it (as minimally and precisely as possible): modify quickstart.sh and run it

The offending line is here. It should assign MINIO_ROOT_PASSWORD.

export S3_SECRET_KEY=${MINIO_ROOT_USER}

I'd submit a PR but there's too much digital paperwork here.

@Vanshikav123
Copy link
Contributor

Hello @scaleoutsean I hope this message finds you well. I'm excited to introduce myself as a new member of the Thanos community. I'm eager to contribute to the organization and help enhance the project. If possible, could you please consider assigning me this issue , I am also open to any guidance or feedback you can provide during the process.

@matej-g
Copy link
Collaborator

matej-g commented Aug 18, 2023

Thanks for the report @scaleoutsean!

And thank you @Vanshikav123, please take it away! This should be straightforward 🙂.

@Vanshikav123
Copy link
Contributor

Thank you @matej-g for assigning me this issue . It would be great help if @scaleoutsean provide me some more information regarding this issue.

@matej-g
Copy link
Collaborator

matej-g commented Aug 18, 2023

@Vanshikav123 I think the issue is quite straightforward - there is mistake in the parameter name, the line that was reported above needs to changed to:

export S3_SECRET_KEY=${MINIO_ROOT_PASSWORD} 

@Vanshikav123
Copy link
Contributor

Thank you @matej-g I have made the changes on my way to push it

@yeya24
Copy link
Contributor

yeya24 commented Aug 18, 2023

Fixed by #6628

@yeya24 yeya24 closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants