-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3/aliyunOSS: Support multipart upload without pre known object size. #678
Comments
Or better: #443 |
The same story is for new provider AliYun. We should either implement multipart on our own or extend objstore interface: https://github.com/thanos-io/thanos/pull/1573/files#r336389276 |
We have a solid use case for this issue to be fixed: observatorium/thanos-replicate#22 Help wanted! |
@bwplotka could move thanos-replicate under thanos-io to increase its exposure and make it look more important for thaons? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is still valid, right? |
yup 👍 |
Hi, @bwplotka @adrien-f For aliyun oss, we can use the resumable upload without known object size. What do you think? |
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Hello 👋 Looks like there was no activity on this issue for last 30 days. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Hi @wujinhu, it seems that this issue hasn't been fixed yet. Do we have any plans for that? Is there some work that I can do for solving it? We use aliyun OSS in our production environment as Thanos bucket store. But we failed to do downsampling jobs because we always get annoying errors And I find there is a todo comment referring to this issue in line 72 in the source file |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
@yeya24 i would like to look into this issue if it's still open |
Discussion for Reference #617
Acceptance Critiria:
Upload(ctx context.Context, name string, r io.Reader)
interface.The text was updated successfully, but these errors were encountered: