Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Frontend: queries with negative offset should check whether it is cacheable or not #6928

Closed
yeya24 opened this issue Nov 26, 2023 · 1 comment · Fixed by #7011
Closed

Query Frontend: queries with negative offset should check whether it is cacheable or not #6928

yeya24 opened this issue Nov 26, 2023 · 1 comment · Fixed by #7011
Labels
bug component: query-frontend help wanted

Comments

@yeya24
Copy link
Contributor

yeya24 commented Nov 26, 2023 •
edited
Loading

Query with negative offset enabled queries latest or even data in the future. This affects the results cache in query frontend and it should respect the max cache freshness config.

Crossposting from cortexproject/cortex#5678 as I believe Thanos has the same issue.
@Vanshikav123
Copy link
Contributor

Hello @yeya24 i want to work on this !

@pawarpranav83 pawarpranav83 mentioned this issue Dec 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component: query-frontend help wanted
Projects
None yet
Milestone
No milestone
2 participants
@yeya24 @Vanshikav123