Problem: tx index is incorrect when there's failed tx in block

[yihuang]

System info: ethermint main branch

Steps to reproduce:

Since failed tx don't increase the tx index in transient store, so the tx index recorded in the log is actually excludes the failed tx, so don't match the tx list in getBlock where there are failed tx in present.

Expected behavior: web3 apis should be consistent with each other

Actual behavior: tx index could be inconsistent

Additional info:

Proposal:

• exclude failed tx from all the web3 apis: getBlock and eth_getTransactionByBlockHashAndIndex, GetTransactionByBlockNumberAndIndex, etc.

[fedekunze]

I see the issue you mention but I don't understand your suggested proposal, can you elaborate? @yihuang

[yihuang]

I see the issue you mention but I don't understand your suggested proposal, can you elaborate? @yihuang

• exclude the failed tx from getBlock API response, so web3 clients don't see the failed tx at all, and the index of the tx list is consistent with what's recorded in the logs.
• fix the eth_getTransactionByBlockHashAndIndex/eth_getTransactionByBlockNumberAndIndex to return correct tx, by skipping the failed tx in the block. currently when there's failed tx in block, it could return wrong tx.

[leejw51crypto]

and those two tx has exactly the same txhash

failedtx , successfultx
txhash == txhash