impr(erc20): Add check to remove tokenPair if contract is suicided #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-360 erc20 module doesnt consider token pairs with suicided contracts
tx would just fail, but that’s a great question and we should check if the contract exists before doing the conversion. If it doesn’t we should remove the token pair from the store |
danburck
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
fedekunze
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a token pair when the erc20 conversion is called on a suicided contract's token pair.
Note that this PR requires a new ethermint release
Closes https://linear.app/tharsis/issue/ENG-360/erc20-module-doesnt-consider-token-pairs-with-suicided-contracts