-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(erc20): registerCoin
deploys erc20 contract with different minimal coin denomination
#200
bug(erc20): registerCoin
deploys erc20 contract with different minimal coin denomination
#200
Conversation
ENG-351 `registerCoin` deploys erc20 contract with different minimal coin denomination
When you register a coin right now with To avoid confusion, we need to create a contract that overrides the decimals on deployment. |
…rnerDecimals contract
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 72.04% 72.15% +0.10%
==========================================
Files 32 32
Lines 2168 2176 +8
==========================================
+ Hits 1562 1570 +8
Misses 534 534
Partials 72 72
|
registerCoin
deploys erc20 contract with different minimal coin denomination
registerCoin
deploys erc20 contract with different minimal coin denominationregisterCoin
deploys erc20 contract with different minimal coin denomination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK! Can you add a bug fix changelog entry too?
Description
Closes: https://linear.app/tharsis/issue/ENG-351/registercoin-deploys-erc20-contract-with-different-minimal-coin
This PR makes sure that the deployed erc20 has the same decimals as the coin during
registerCoin
.