Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a non-Core FFXIV database plugin on which other FFXIV plugins can depend on #74

Open
3 tasks
MKhayle opened this issue May 19, 2022 · 3 comments
Open
3 tasks
Labels
enhancement New feature or request non-core module Priority P2 unblocks some work, required to be done before other things

Comments

@MKhayle
Copy link

MKhayle commented May 19, 2022

Describe the solution you'd like

Allow an internal use of FFXIV data through a database plugin so that other FFXIV plugins can rely on it to handle FFXIV data easily and in a consistent manner, with localization supported across all 4 languages of the game.

This module should also handle basic built-in commands (from #3, thanks @ArcaneDisgea) :

  • Item Queries
  • Action Queries
  • Recipe Queries

Additional context
/item "Antidote"
/action "Shukuchi"
/recipe "Shishi-odoshi"

@MKhayle MKhayle added the enhancement New feature or request label May 19, 2022
@project-automations project-automations bot moved this to Todo ✏️ in MVP May 19, 2022
@ArcaneDisgea
Copy link
Contributor

Prolly want to include a language field to these queries unless we want to store preferred language of a user in db and let them use a /lang command also exploitable prolly isn't a great word for that.

@MKhayle
Copy link
Author

MKhayle commented May 19, 2022

Edited it out, turns out the nuances of the word differs a bit in fr/en (and how it's being used, I guess)

Do we want to store preferred languages ?

@ArcaneDisgea
Copy link
Contributor

That's how other bots do it to my knowledge. Since those bots tend to have reputation systems for a guild and store the lodestone character data attached to that discord user, they also just store language as an additional user-defineable field that gets referenced for any commands that would need to care about language.

If we added this we would want to add a default language field that can be set for the guild and then a user-defineable one that overrides the guild setting for a particular user.

If this was done @karashiiro could ditch the language field on /market and just reference whatevers set in the db.

@MKhayle MKhayle changed the title Implement a non-Core FFXIV database module on which other modules can depend on Implement a non-Core FFXIV database plugin on which other FFXIV plugins can depend on May 20, 2022
@kalilistic kalilistic added Priority P3 ordinary flow of work Priority P2 unblocks some work, required to be done before other things and removed Priority P3 ordinary flow of work labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request non-core module Priority P2 unblocks some work, required to be done before other things
Projects
Status: Todo ✏️
Development

No branches or pull requests

4 participants