Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V-EAT can print unnecessary blank line #14

Open
eriktorbjorn opened this issue Feb 23, 2021 · 0 comments
Open

V-EAT can print unnecessary blank line #14

eriktorbjorn opened this issue Feb 23, 2021 · 0 comments

Comments

@eriktorbjorn
Copy link

eriktorbjorn commented Feb 23, 2021

I managed to reproduce this in Zork III:

>DRINK BREAD
You're not holding that.


>

That's because of this bit in V-EAT:

         <COND (<SET EAT? <FSET? ,PRSO ,FOODBIT>>
                <COND (<AND <NOT <IN? ,PRSO ,WINNER>>
                            <NOT <IN? <LOC ,PRSO> ,WINNER>>>
                       <TELL "You're not holding that." CR>)
                      (<VERB? DRINK>
                       <TELL "How can you drink that?">)
                      (T
                       <TELL "Thank you very much. It really hit the spot.">
                       <REMOVE-CAREFULLY ,PRSO>)>
                <CRLF>)

So it prints a CR after "You're not holding that." and then it calls <CRLF> anyway.

Note that this probably cannot be reproduced with the EAT command, because that verb automatically picks up the object. (It probably makes sense that you don't automatically pick up things on DRINK, because that's likely to be a liquid.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant