-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignored attempt to cancel a touchmove event with cancelable=false #8
Comments
Is there an easy way to reproduce this problem? |
Yes, use the chrome emulator in e.g iPad mode and scroll on the wrapped element. |
I've just noticed the same problem. FWIW, it doesn't actually seem to manifest in any bugs. |
And it's not reproducible for me (OSX, Chrome 74), including real mobile devices (testing iOS only, sorry). I'll use |
It does not result in any bug but in lots of errors in the console. I think to rely on |
I saw many warning around canceling touch/scroll events, which are cancelable, but canceling them would lead to a bad used experience, bla, bla, bla. But that's what we are doing here :) |
What is the latest on this? |
I'm getting this same error when I have a dialog with horizontally scrollable element in it. The element seems to work fine on my Android phone but the console is filled with error on Chrome simulator. Is there anything I could do on my app's side to avoid this or should I just shrug it off? I'm using this library as a dependency of reach ui's dialog component: https://github.com/reach/reach-ui |
I'll check |
Any news on this? |
Oof, time flies. |
Still occurs. Is there any resolution on this? UPDATE: I actually figured out when it happens exactly. If I scrolled all the way down and released my finger from the screen and try to scroll down more - it's not showing any errors/warnings. But if I drag my finger up or down the screen and reach the end of the scrollable area, but continue the dragging - only then it shows this error in the console. |
I have updated my previous comment to include more insight on when it happens (at least for me). |
Hello!
Seems to be coming from
should we add a check here as well with |
I'm facing the same issue. As @thexpand mentioned I'm able to reproduce this error with the same steps:
|
hello, I see the error
in the console when I use touch events on the scrollable area.
This issue happens because https://github.com/theKashey/react-remove-scroll/blob/master/src/component.tsx#L101 can't be canceled!
A possible solution is described here
The text was updated successfully, but these errors were encountered: