Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"featured_image" behaves strangely if a URL link is in the description before the "more" separator. #50

Closed
zo0o0ot opened this issue Sep 21, 2017 · 4 comments
Assignees
Labels

Comments

@zo0o0ot
Copy link

zo0o0ot commented Sep 21, 2017

I was confused by the size of my "featured_image" images changing to much smaller size on my index page seemingly at random.

I then figured out that my latest change introduced description text that included URL links in this format:

_The morning of a Packer Game - [The NFC Championship in Green Bay before Super Bowl XXXI](http://www.pro-football-reference.com/boxscores/199701120gnb.htm)._

If I include text like this before the <!--more--> separator, things get wonky. If I include only text before the <!--more-->, everything returns to normal. Right now, that's my workaround, but it'd be nice if this was fixed.

@budparr
Copy link
Member

budparr commented Oct 12, 2017

@zo0o0ot Are you talking about the description in front matter? If I put that copy in the front matter I see that it doesn't render as HTML, but it doesn't change the image. Just want to make sure we get the right solution for you.

@zo0o0ot
Copy link
Author

zo0o0ot commented Oct 13, 2017

I'm referring to the behavior of the main page of the site if there are posts with preview images and links in their description.

I actually had issues with the images resizing in unexpected ways if I had text with a link in the first portion of the post, before the <!--more--> separator. If the links were after the <!--more--> separator, everything seemed fine.

On my site, I fixed the issue with this commit: sermonarchives/blog@cc3dcaf

This was a sidestep of the main issue, I just moved all links out of the descriptions.

@budparr
Copy link
Member

budparr commented Oct 13, 2017

Okay. I previously thought you were talking about the hero images, so I'll check it out and see what I can do.

@budparr budparr self-assigned this Oct 13, 2017
@budparr budparr added the bug label Oct 13, 2017
@budparr
Copy link
Member

budparr commented Oct 16, 2017

Thanks for letting me know about this @zo0o0ot Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants