-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Telemetry DataFrame should include DriverId #484
Comments
What you are proposing is to add a column (or two, probably) containing driver abbreviation and/or driver number, right?
What purpose do you see for this functionality? |
Yeah adding the column(s) would be preferred. The addition of |
Having mixed telemetry DataFrames with data from multiple drivers was never intended functionality. I'm not necessarily against doing this. But I don't see a real benefit at the moment. What exactly is the use case that you see? Why would that improve functionality or user experience? |
Thanks for taking the time to expand on the various functions of I'm not particularly attached to this suggestion, so feel free to call it too much work and close without action. It's a lot of work for what is essentially just saving the user the hassle of binding multiple |
Can you maybe give a concrete example where this would be a noticeable improvement? If this is instead something that would make things easier for the R wrapper, that would be something we can discuss as well. |
I think we had some discussion on this for the R wrapper, there were some specific tasks that would have been way easier (for us) with this enabled in Python. I think too though that merging data frames of telemetries is likely easier than re-writing the whole @SCasanova, can you share the use case for multiple driver telemetries extraction at once? This comes from working on SCasanova/f1dataR#78 |
Hey! Yeah of course The idea behind this is for when one is building a model that uses mass data from a race. Mainly simplifying the extraction process of telem for more than one driver without having to use a for loop on our end |
The API provides this data as one time series for each driver. This data is currently not merged in FastF1. So the question becomes, where do we loop over the data to merge it. (To be fair, I could maybe do it without an explicit loop in Python, but I'm not sure if that would even be more efficient. And the loop would then probably just be inside Pandas or Numpy code.) |
I think this is going to be about equally difficult in Python as it is/was in R. Given the need to refactor methods should multiple drivers' telemetries be passed simultaneously, I think we can handle it with loops in R (or let the end user do so if they wish). I'm fine to close this as "won't implement". |
Proposed new feature or change:
Telemetry DataFrame should include the DriverId.
Rationale:
session.laps.pick_fastest().get_telemetry()
) in which case extra work is required to see who that telemetry belongs to.The text was updated successfully, but these errors were encountered: