[portorch] parse on/off value from autoneg (sonic-net#1658)

Changed parsing autoneg from 1/0 to on/off

Author: dmytroxshevchuk

orchagent/portsorch.cpp

@@ -2228,7 +2228,7 @@ void PortsOrch::doPortTask(Consumer &consumer)
                 /* Set autoneg and ignore the port speed setting */
                 else if (fvField(i) == "autoneg")
                 {
-                    an = (int)stoul(fvValue(i));
+                    an = (fvValue(i) == "on");
                 }
                 /* Set port serdes Pre-emphasis */
                 else if (fvField(i) == "preemphasis")

tests/test_port_an.py

@@ -12,8 +12,8 @@ def test_PortAutoNegCold(self, dvs, testlog):
 
         tbl = swsscommon.ProducerStateTable(db, "PORT_TABLE")
 
-        # set autoneg = false and speed = 1000
-        fvs = swsscommon.FieldValuePairs([("autoneg","1"), ("speed", "1000")])
+        # set autoneg = true and speed = 1000
+        fvs = swsscommon.FieldValuePairs([("autoneg","on"), ("speed", "1000")])
 
         tbl.set("Ethernet0", fvs)
 
@@ -50,7 +50,7 @@ def test_PortAutoNegCold(self, dvs, testlog):
                 assert fv[1] == "1:100"
 
         # change autoneg to false
-        fvs = swsscommon.FieldValuePairs([("autoneg","0")])
+        fvs = swsscommon.FieldValuePairs([("autoneg","off")])
 
         tbl.set("Ethernet0", fvs)
 
@@ -99,7 +99,7 @@ def test_PortAutoNegWarm(self, dvs, testlog):
         stbl = swsscommon.Table(sdb, "PORT_TABLE")
 
         # set autoneg = true and speed = 1000
-        fvs = swsscommon.FieldValuePairs([("autoneg","1"), ("speed", "1000")])
+        fvs = swsscommon.FieldValuePairs([("autoneg","on"), ("speed", "1000")])
         ctbl.set("Ethernet0", fvs)
 
         time.sleep(1)