Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio.transaction set method is throwing error when same code used with old and new versions #481

Open
rm-vt opened this issue Mar 28, 2024 · 2 comments

Comments

@rm-vt
Copy link

rm-vt commented Mar 28, 2024

Thanks for inventing this framework/lib.

Facing issues with studio.transaction set method.

Current package versions which is throwing error on set method

"@theatre/core": "^0.7.0",
"@theatre/studio": "^0.7.0",
"next": "14.1.0",

Old package versions - no error

"@theatre/core": "^0.4.7",
"@theatre/studio": "^0.4.7",
"react": "^17.0.2",
"react-dom": "^17.0.2"

TheatreSheetObject props(proxy object) shows diff implementation get(obj, props) vs get(pointerKey, prop)
Right-side old version - ^0.4.7
Left-side new version - ^0.7.0
image

TheatreSheetObject implementation is different across versions
image

Please help. Thanks.

@rm-vt rm-vt changed the title studio.transcation set method is throwing error when same code used with old and new versions studio.transaction set method is throwing error when same code used with old and new versions Mar 28, 2024
@AriaMinaei
Copy link
Member

@rm-vt This looks interesting. Is there any way you can share a reproduction on Stackblitz/Codesandbox/Git repo?

@rm-vt
Copy link
Author

rm-vt commented Apr 11, 2024

Sure. @AriaMinaei

Setup with old package versions:
https://codesandbox.io/p/devbox/theatre-js-svg-animation-updated-forked-n63dy7

Setup with new package versions:
https://codesandbox.io/p/devbox/threatrejs-nextjs-latest-svg-l98nvw

Please drag the robot hand as pointed out on both of the above setup to see the error!

image

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants