-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints #218
Comments
If you look at what that type actually is (i.e. whatever the type of Calling the modulefinder code "somewhat esoteric" is a bit of an understatement :-) MyModuleFinder is a thin layer on top of the Python std library I like types, but Python's type system is horrendously anemic and excessively verbose, e.g. the typing of
how many lines of type code do you need to write to get this to work in Python..? I'll get off my soap-box now :-D ps: PRs that add sensible typings (api interface boundaries) will likely be merged... |
The current lack of type hinting is hindering using the API since there's a few somewhat esoteric parts.
Ideally comments like the DepGraph init comment:
# depgraph is py2depgraph.MyModulefinder._depgraph
would just have the actual type hinted.
The text was updated successfully, but these errors were encountered: