Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom scalar types already resolved through webonyx/graphql #733

Open
deeky666 opened this issue Mar 5, 2025 · 0 comments
Open

Custom scalar types already resolved through webonyx/graphql #733

deeky666 opened this issue Mar 5, 2025 · 0 comments

Comments

@deeky666
Copy link

deeky666 commented Mar 5, 2025

Hi,

I recently made an observation that ScalarType::parseValue() is called twice for custom scalars.

This is due to webonyx/graphql already resolving ScalarType and EnumType by itself while GraphQLite is trying to resolve it again. Obviously this observation already has been made for Enums but not for Scalars:

GraphQL\Utils\Value

Image

TheCodingMachine\GraphQLite\Types\ArgumentResolver

Image

I guess the second resolve call can be omitted then if we have a ScalarType :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant