Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4.1 compatibility? #50

Closed
jscheid opened this issue Nov 2, 2014 · 3 comments
Closed

Rails 4.1 compatibility? #50

jscheid opened this issue Nov 2, 2014 · 3 comments

Comments

@jscheid
Copy link

jscheid commented Nov 2, 2014

Hi,

Is this supposed to work with Rails 4.1? I don't actually know what precisely your Gem is doing to speed things up, but it doesn't appear to fix the problem of asset requests checking for updated classes. In fact it seems to make it worse, loading a simple asset takes ~2 seconds with rails_dev_boost. Am I doing something wrong or is 4.1 just not supported (yet)?

@thedarkone
Copy link
Owner

Rails 4.1 should be supported. I just created an empty Rails 4.1 app, added rails-dev-boost gem, but wasn't able to reproduce the reported slow down.

Serving a simple tester.css.scss (via http://127.0.0.1:3000/assets/tester.css, tested with a simple ab -n 1000 http://127.0.0.1:3000/assets/tester.css) is giving me:

  • about 380 requests per second without rails-dev-boost,
  • and about 420 req/s with rails-dev-boost

@jscheid do you think you would be able to create a sample app, so I could poke around and see what is causing the problem for you?

@thedarkone
Copy link
Owner

ping @jscheid.

Do you have any updates on this? I think your issue might be somewhat related to #43 (where @obromios reported a similar assets related slow down, but I wasn't able to reproduce).

@jscheid
Copy link
Author

jscheid commented Dec 13, 2014

Hi @thedarkone, sorry I didn't get back to you earlier.

To be honest, at least for our app I don't have a need for this project or related hacks/workarounds anymore.

For what it's worth, the change that made everything work quite snappy with Rails 4.1 for us was removing all the hacks and adding this setting:

config.assets.raise_runtime_errors = false

Just to clarify, I don't know if that means your project isn't useful in Rails 4.1, your timings above seem to indicate it can improve matters. All I'm saying is that in our case, the app now performs well enough in dev mode without it.

I can't provide you with a sample app -- the app with which I experienced the original problem isn't open source, and making a separate app for reproducing the issue would be quite a lot of work for which I just don't have the time.

Feel free to close this issue and sorry I can't be of more help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants