-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$listen_on_interface in foreman::config::passenger doesn't accept interfaces #649
Comments
okay I did some more debugging. My initial conclusion was horribly wrong here. The puppetlabs-apache module provides a default vhost. it listens on port 80 on all ip addresses / interfaces. Setting ---
apache::default_vhost: false and everything is working as expected. |
We do indeed set apache::default_vhost to false in our installer (via hiera) but we don't want to manage this in this module so it's left as a users exercise now. #563 is open to make this more generic so I'm linking it here. |
hai everybody,
let's assume somebody did something like this in hiera;
from the class description:
puppet-foreman/manifests/config/passenger.pp
Lines 7 to 8 in 4a1f028
So I assume an interface name is supposed to be valid. Later on we parse the name like this:
puppet-foreman/manifests/config/passenger.pp
Lines 115 to 120 in 4a1f028
And pass it to an
apache::vhost
defined resource:puppet-foreman/manifests/config/passenger.pp
Lines 141 to 145 in 4a1f028
But from the
puppetlabs-apache
module:https://github.com/puppetlabs/puppetlabs-apache/blob/1ab05064a8e93a0e8bdae73dc673b0a095d1c629/manifests/vhost.pp#L367-L370
$add_listen defaults to true and the foreman module doesn't expose a parameter to disable it. That means that the defined resource expects an IP-Address and not an interface name. Foreman throws this error message:
My Puppet code to trigger this, without hiera:
The text was updated successfully, but these errors were encountered: